Re: 2.6.17-rc5-mm3: bad unlock ordering (reiser4?)

Hans Reiser
2006-06-09T21:36:24Z

Ingo Molnar wrote:

> if (atomic_read(&node->d_count) != 0) {
> return 0;
> }
>
>why the braces, when on the next line it's not done:
>
> if (blocknr_is_fake(jnode_get_block(node)))
> return 0;
>
>it looks quite inconsistent.
>
I have a (roughly adhered to) rule that I don't hassle programmers much
about the style of any code that I can easily read. I truly do not care
where the braces are, I care if the comments and variable names are well
done. So that is why, and yes, I know I am an unusual manager on this
point.