From: Ingo Molnar <mingo@elte.hu>
To: Jan Kara <jack@suse.cz>
Cc: Arjan van de Ven <arjan@linux.intel.com>,
Valdis.Kletnieks@vt.edu, linux-kernel@vger.kernel.org,
Andrew Morton <akpm@osdl.org>
Subject: Re: 2.6.17-rc5-mm3-lockdep - locking error in quotaon
Date: Mon, 5 Jun 2006 22:15:10 +0200 [thread overview]
Message-ID: <20060605201510.GA15907@elte.hu> (raw)
In-Reply-To: <20060605200652.GC24342@atrey.karlin.mff.cuni.cz>
* Jan Kara <jack@suse.cz> wrote:
> > but that doesn't quite match your description...
> This piece of code is there just because we avoid page cache when
> doing quota writes. That is a different story and should cause problems
> with your lock checker.
> Standard way of running quota is:
> - get i_mutex for data_inode
> - write some data to data_inode
> - requires allocation -> calls DQUOT_ALLOC_SPACE
> - DQUOT_ALLOC_SPACE acquires some quota locks, decides it wants to
> write out quota structure (e.g. because we are journaling quota and
> must preserve quota integrity)
> - acquires dqio_sem, calls filesystem specific quota writing
> function - e.g. ext3_quota_write()
> - this function acquires i_mutex for quota file
>
> I think this is the type of circle your checker has found.
the validator noticed a circular dependency (AB->BA, or AB->BC->CA,
etc.) - while the nesting above it would report as: "BUG: possible
deadlock detected!".
Ingo
next prev parent reply other threads:[~2006-06-05 20:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-05 17:00 2.6.17-rc5-mm3-lockdep - locking error in quotaon Valdis.Kletnieks
2006-06-05 17:25 ` Arjan van de Ven
2006-06-05 17:35 ` Jan Kara
2006-06-05 19:20 ` Valdis.Kletnieks
2006-06-05 19:35 ` Jan Kara
2006-06-05 19:52 ` Arjan van de Ven
2006-06-05 20:06 ` Jan Kara
2006-06-05 20:15 ` Ingo Molnar [this message]
2006-06-05 20:26 ` Arjan van de Ven
2006-06-06 2:22 ` Valdis.Kletnieks
2006-06-06 8:33 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060605201510.GA15907@elte.hu \
--to=mingo@elte.hu \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@osdl.org \
--cc=arjan@linux.intel.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox