Re: [PATCH -mm] misroute-irq: Don't call desc->chip->end because of edge interrupts

Andrew Morton
2006-06-06T21:48:53Z

On Tue, 06 Jun 2006 06:50:19 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 2006-06-06 at 10:01 +0200, Ingo Molnar wrote:
> > * Steven Rostedt <rostedt@goodmis.org> wrote:
> >
> > > Hit the following BUG with irqpoll. The below patch fixes it.
> >
> > > - if (work)
> > > + if (work && disc->chip && desc->chip->end)
> > > desc->chip->end(i);
> >

Why is this change necessary? 2.6.17-rc6 doesn't have it, and it doesn't
oops. So somebody changed something. What? Why? Was it intentional? Was
it correct?

>
> As for eio, could be. This was part of my whole misroute thing which I
> didn't have time to get to deep in. I'm leaving today, where I won't
> have any computers or Internet til next Wednesday or Thursday, so I'm
> not going to be able to work on this further till then.

If "could be" == "yes" then what would be the consequences of this
bug-which-were-not-sure-is-there-yet?