From: Con Kolivas <kernel@kolivas.org>
To: linux-kernel@vger.kernel.org
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
nickpiggin@yahoo.com.au, mingo@elte.hu, pwil3058@bigpond.net.au,
akpm@osdl.org
Subject: Re: [Patch] sched: mc/smt power savings sched policy
Date: Wed, 7 Jun 2006 09:59:08 +1000 [thread overview]
Message-ID: <200606070959.09216.kernel@kolivas.org> (raw)
In-Reply-To: <20060606112521.A18026@unix-os.sc.intel.com>
On Wednesday 07 June 2006 04:25, Siddha, Suresh B wrote:
> Appended the patch. Can someone please test compile the powerpc change?
>
> thanks,
> suresh
> --
>
> sysfs entries 'sched_mc_power_savings' and 'sched_smt_power_savings' in
> /sys/devices/system/cpu/ control the MC/SMT power savings policy for
> the scheduler.
>
> Based on the values (1-enable, 0-disable) for these controls, sched groups
> cpu power will be determined for different domains. When power savings
> policy is enabled and under light load conditions, scheduler will minimize
> the physical packages/cpu cores carrying the load and thus conserving
> power(with a perf impact based on the workload characteristics... see OLS
> 2005 CMP kernel scheduler paper for more details..)
This MC code is a maze of #ifdefs within functions and getting harder to
follow with each subsequent patch. Can we not deviate so much from kernel
style?
--
-ck
next prev parent reply other threads:[~2006-06-06 23:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-06 18:25 [Patch] sched: mc/smt power savings sched policy Siddha, Suresh B
2006-06-06 23:59 ` Con Kolivas [this message]
2006-06-07 1:06 ` Siddha, Suresh B
2006-06-07 16:49 ` Andrew Morton
2006-06-07 17:29 ` Siddha, Suresh B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200606070959.09216.kernel@kolivas.org \
--to=kernel@kolivas.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nickpiggin@yahoo.com.au \
--cc=pwil3058@bigpond.net.au \
--cc=suresh.b.siddha@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox