* [PATCH] Get rid of /proc/sys/proc
@ 2006-06-07 21:21 Stephen Hemminger
2006-06-07 21:22 ` [PATCH] Get rid of /proc/sys/debug Stephen Hemminger
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2006-06-07 21:21 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
The table is empty, why does it still exist?
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- a/kernel/sysctl.c 2006-04-27 11:12:54.000000000 -0700
+++ b/kernel/sysctl.c 2006-06-07 14:06:38.000000000 -0700
@@ -142,7 +142,6 @@
static ctl_table kern_table[];
static ctl_table vm_table[];
-static ctl_table proc_table[];
static ctl_table fs_table[];
static ctl_table debug_table[];
static ctl_table dev_table[];
@@ -202,12 +201,6 @@
},
#endif
{
- .ctl_name = CTL_PROC,
- .procname = "proc",
- .mode = 0555,
- .child = proc_table,
- },
- {
.ctl_name = CTL_FS,
.procname = "fs",
.mode = 0555,
@@ -918,10 +911,6 @@
{ .ctl_name = 0 }
};
-static ctl_table proc_table[] = {
- { .ctl_name = 0 }
-};
-
static ctl_table fs_table[] = {
{
.ctl_name = FS_NRINODE,
--- a/include/linux/sysctl.h 2006-04-27 11:12:53.000000000 -0700
+++ b/include/linux/sysctl.h 2006-06-07 14:12:29.000000000 -0700
@@ -55,7 +55,7 @@
CTL_KERN=1, /* General kernel info and control */
CTL_VM=2, /* VM management */
CTL_NET=3, /* Networking */
- CTL_PROC=4, /* Process info */
+ /* was CTL_PROC */
CTL_FS=5, /* Filesystems */
CTL_DEBUG=6, /* Debugging */
CTL_DEV=7, /* Devices */
@@ -762,8 +762,6 @@
NET_BRIDGE_NF_FILTER_VLAN_TAGGED = 4,
};
-/* CTL_PROC names: */
-
/* CTL_FS names: */
enum
{
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] Get rid of /proc/sys/debug
2006-06-07 21:21 [PATCH] Get rid of /proc/sys/proc Stephen Hemminger
@ 2006-06-07 21:22 ` Stephen Hemminger
2006-06-07 21:45 ` Randy.Dunlap
0 siblings, 1 reply; 4+ messages in thread
From: Stephen Hemminger @ 2006-06-07 21:22 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
Another empty table with no entries.
Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
--- sky2.orig/include/linux/sysctl.h 2006-06-07 14:12:29.000000000 -0700
+++ sky2/include/linux/sysctl.h 2006-06-07 14:20:15.000000000 -0700
@@ -57,7 +57,7 @@
CTL_NET=3, /* Networking */
/* was CTL_PROC */
CTL_FS=5, /* Filesystems */
- CTL_DEBUG=6, /* Debugging */
+ /* was CTL_DEBUG */
CTL_DEV=7, /* Devices */
CTL_BUS=8, /* Busses */
CTL_ABI=9, /* Binary emulation */
@@ -800,8 +800,6 @@
FS_DQ_WARNINGS = 9,
};
-/* CTL_DEBUG names: */
-
/* CTL_DEV names: */
enum {
DEV_CDROM=1,
--- sky2.orig/kernel/sysctl.c 2006-06-07 14:06:38.000000000 -0700
+++ sky2/kernel/sysctl.c 2006-06-07 14:18:34.000000000 -0700
@@ -143,7 +143,6 @@
static ctl_table kern_table[];
static ctl_table vm_table[];
static ctl_table fs_table[];
-static ctl_table debug_table[];
static ctl_table dev_table[];
extern ctl_table random_table[];
#ifdef CONFIG_UNIX98_PTYS
@@ -207,12 +206,6 @@
.child = fs_table,
},
{
- .ctl_name = CTL_DEBUG,
- .procname = "debug",
- .mode = 0555,
- .child = debug_table,
- },
- {
.ctl_name = CTL_DEV,
.procname = "dev",
.mode = 0555,
@@ -1037,10 +1030,6 @@
{ .ctl_name = 0 }
};
-static ctl_table debug_table[] = {
- { .ctl_name = 0 }
-};
-
static ctl_table dev_table[] = {
{ .ctl_name = 0 }
};
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Get rid of /proc/sys/debug
2006-06-07 21:22 ` [PATCH] Get rid of /proc/sys/debug Stephen Hemminger
@ 2006-06-07 21:45 ` Randy.Dunlap
2006-06-07 21:49 ` Stephen Hemminger
0 siblings, 1 reply; 4+ messages in thread
From: Randy.Dunlap @ 2006-06-07 21:45 UTC (permalink / raw)
To: Stephen Hemminger; +Cc: akpm, linux-kernel
On Wed, 7 Jun 2006 14:22:32 -0700 Stephen Hemminger wrote:
> Another empty table with no entries.
Did you check on x86_64? I see this:
rddunlap@midway:/var/linsrc/linux-2617-rc6> ll /proc/sys/debug
-rw-r--r-- 1 root root 0 2006-06-07 14:44 exception-trace
from arch/x86_64/mm/init.c
> Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
> --- sky2.orig/include/linux/sysctl.h 2006-06-07 14:12:29.000000000 -0700
> +++ sky2/include/linux/sysctl.h 2006-06-07 14:20:15.000000000 -0700
> @@ -57,7 +57,7 @@
> CTL_NET=3, /* Networking */
> /* was CTL_PROC */
> CTL_FS=5, /* Filesystems */
> - CTL_DEBUG=6, /* Debugging */
> + /* was CTL_DEBUG */
> CTL_DEV=7, /* Devices */
> CTL_BUS=8, /* Busses */
> CTL_ABI=9, /* Binary emulation */
> @@ -800,8 +800,6 @@
> FS_DQ_WARNINGS = 9,
> };
>
> -/* CTL_DEBUG names: */
> -
> /* CTL_DEV names: */
> enum {
> DEV_CDROM=1,
> --- sky2.orig/kernel/sysctl.c 2006-06-07 14:06:38.000000000 -0700
> +++ sky2/kernel/sysctl.c 2006-06-07 14:18:34.000000000 -0700
> @@ -143,7 +143,6 @@
> static ctl_table kern_table[];
> static ctl_table vm_table[];
> static ctl_table fs_table[];
> -static ctl_table debug_table[];
> static ctl_table dev_table[];
> extern ctl_table random_table[];
> #ifdef CONFIG_UNIX98_PTYS
> @@ -207,12 +206,6 @@
> .child = fs_table,
> },
> {
> - .ctl_name = CTL_DEBUG,
> - .procname = "debug",
> - .mode = 0555,
> - .child = debug_table,
> - },
> - {
> .ctl_name = CTL_DEV,
> .procname = "dev",
> .mode = 0555,
> @@ -1037,10 +1030,6 @@
> { .ctl_name = 0 }
> };
>
> -static ctl_table debug_table[] = {
> - { .ctl_name = 0 }
> -};
> -
> static ctl_table dev_table[] = {
> { .ctl_name = 0 }
> };
---
~Randy
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Get rid of /proc/sys/debug
2006-06-07 21:45 ` Randy.Dunlap
@ 2006-06-07 21:49 ` Stephen Hemminger
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2006-06-07 21:49 UTC (permalink / raw)
To: Randy.Dunlap; +Cc: akpm, linux-kernel
On Wed, 7 Jun 2006 14:45:12 -0700
"Randy.Dunlap" <rdunlap@xenotime.net> wrote:
> On Wed, 7 Jun 2006 14:22:32 -0700 Stephen Hemminger wrote:
>
> > Another empty table with no entries.
>
> Did you check on x86_64? I see this:
>
> rddunlap@midway:/var/linsrc/linux-2617-rc6> ll /proc/sys/debug
> -rw-r--r-- 1 root root 0 2006-06-07 14:44 exception-trace
>
> from arch/x86_64/mm/init.c
It looks like if we left the CTL_DEBUG enum, then the x86_64 code would
still work because it registers starting at /proc/sys so the debug directory
would then be created only if needed.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-06-07 21:49 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-07 21:21 [PATCH] Get rid of /proc/sys/proc Stephen Hemminger
2006-06-07 21:22 ` [PATCH] Get rid of /proc/sys/debug Stephen Hemminger
2006-06-07 21:45 ` Randy.Dunlap
2006-06-07 21:49 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox