PNX8550 fails to compile in 2.6.17-rc4

PNX8550 fails to compile in 2.6.17-rc4

[Vitaly Wool]

Hi folks,

when I try to compile Linux kernel for pnx8550 in 2.6.17-rc4, I get the following error:

  CC      arch/mips/philips/pnx8550/common/setup.o
/home/vital/work/opensource/mtd/arch/mips/philips/pnx8550/common/setup.c: In function `plat_setup':
/home/vital/work/opensource/mtd/arch/mips/philips/pnx8550/common/setup.c:133: warning: implicit declaration of function `ip3106_lcr'
/home/vital/work/opensource/mtd/arch/mips/philips/pnx8550/common/setup.c:134: error: invalid lvalue in assignment
/home/vital/work/opensource/mtd/arch/mips/philips/pnx8550/common/setup.c:135: warning: implicit declaration of function `ip3106_baud'
/home/vital/work/opensource/mtd/arch/mips/philips/pnx8550/common/setup.c:135: error: invalid lvalue in assignment
make[2]: *** [arch/mips/philips/pnx8550/common/setup.o] Error 1
make[1]: *** [arch/mips/philips/pnx8550/common] Error 2
make: *** [vmlinux] Error 2

I guess it's not what it should be ;-)

Vitaly

Re: PNX8550 fails to compile in 2.6.17-rc4

[Ralf Baechle]

On Wed, Jun 07, 2006 at 10:52:21AM +0400, Vitaly Wool wrote:

> when I try to compile Linux kernel for pnx8550 in 2.6.17-rc4, I get the following error:
> 
>   CC      arch/mips/philips/pnx8550/common/setup.o
> /home/vital/work/opensource/mtd/arch/mips/philips/pnx8550/common/setup.c: In function `plat_setup':
> /home/vital/work/opensource/mtd/arch/mips/philips/pnx8550/common/setup.c:133: warning: implicit declaration of function `ip3106_lcr'
> /home/vital/work/opensource/mtd/arch/mips/philips/pnx8550/common/setup.c:134: error: invalid lvalue in assignment
> /home/vital/work/opensource/mtd/arch/mips/philips/pnx8550/common/setup.c:135: warning: implicit declaration of function `ip3106_baud'
> /home/vital/work/opensource/mtd/arch/mips/philips/pnx8550/common/setup.c:135: error: invalid lvalue in assignment
> make[2]: *** [arch/mips/philips/pnx8550/common/setup.o] Error 1
> make[1]: *** [arch/mips/philips/pnx8550/common] Error 2
> make: *** [vmlinux] Error 2
> 
> I guess it's not what it should be ;-)

This seems to be one of the serial bits for the ip3106 which must have
been lost on the way to kernel.org.  Unfortunately the original author
does no longer take care of the code.  I just took a stab at the PNX8550
code and it has a significant number of other problems.  All small in
the sum large enough such that I will mark PNX8550 support broken.

  Ralf

[MIPS] Mark PNX8550 support broken.
    
Broken in too many way for me to fix it for 2.6.17.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

diff --git a/arch/mips/Kconfig b/arch/mips/Kconfig
index 0e25c1d..d87177f 100644
--- a/arch/mips/Kconfig
+++ b/arch/mips/Kconfig
@@ -440,12 +440,12 @@ config MIPS_XXS1500
 
 config PNX8550_V2PCI
 	bool "Philips PNX8550 based Viper2-PCI board"
-	select PNX8550
+	select PNX8550 && BROKEN
 	select SYS_SUPPORTS_LITTLE_ENDIAN
 
 config PNX8550_JBS
 	bool "Philips PNX8550 based JBS board"
-	select PNX8550
+	select PNX8550 && BROKEN
 	select SYS_SUPPORTS_LITTLE_ENDIAN
 
 config DDB5074

Re: PNX8550 fails to compile in 2.6.17-rc4

[Ralf Baechle]

On Wed, Jun 07, 2006 at 12:29:03PM -0300, reservas@morrodaspedras.com wrote:
> 
> Please, dont wright no more for me. Tanks.

Then don't subscribe to mailing lists or have word with the person
who did.  And since you don't seem to look at mail headers, we did
not write to you personally.

  Ralf

Re: PNX8550 fails to compile in 2.6.17-rc4

[Ralf Baechle]

On Mon, Jun 12, 2006 at 12:21:57AM +0400, Vitaly Wool wrote:

> On 6/7/06, Ralf Baechle <ralf@linux-mips.org> wrote:
> >This seems to be one of the serial bits for the ip3106 which must have
> >been lost on the way to kernel.org.  Unfortunately the original author
> >does no longer take care of the code.  I just took a stab at the PNX8550
> >code and it has a significant number of other problems.  All small in
> >the sum large enough such that I will mark PNX8550 support broken.
> 
> I took an attempt to compile 2.6.16.20 kernel from linux-mips.org for
> PNX8550 and it went a little further but also failed soon:
> 
>  CC      arch/mips/philips/pnx8550/common/platform.o
> /home/vital/work/opensource/linux-
> 2.6.16.20/arch/mips/philips/pnx8550/common/platform.c:101: error: variable
> `pnx8550_usb_ohci_device' has initializer but incomplete type
> /home/vital/work/opensource/linux-
> 2.6.16.20/arch/mips/philips/pnx8550/common/platform.c:102: error: unknown
> field `name' specified in initializer
> /home/vital/work/opensource/linux-
> 2.6.16.20/arch/mips/philips/pnx8550/common/platform.c:102: warning: excess
> elements in struct initializer
> /home/vital/work/opensource/linux-
> 2.6.16.20/arch/mips/philips/pnx8550/common/platform.c:102: warning: (near
> initialization for `pnx8550_usb_ohci_device')
> /home/vital/work/opensource/linux-
> 2.6.16.20/arch/mips/philips/pnx8550/common/platform.c:103: error: unknown
> field `id' specified in initializer
> /home/vital/work/opensource/linux-
> 2.6.16.20/arch/mips/philips/pnx8550/common/platform.c:103: warning: excess
> elements in struct initializer
> ...
> /home/vital/work/opensource/linux-
> 2.6.16.20/arch/mips/philips/pnx8550/common/platform.c:101: error: storage
> size of `pnx8550_usb_ohci_device' isn't known
> /home/vital/work/opensource/linux-
> 2.6.16.20/arch/mips/philips/pnx8550/common/platform.c:112: error: storage
> size of `pnx8550_uart_device' isn't known
> make[2]: *** [arch/mips/philips/pnx8550/common/platform.o] Error 1
> make[1]: *** [arch/mips/philips/pnx8550/common] Error 2
> make: *** [vmlinux] Error 2
> 
> Does it make sense to try to fix those? Or will it only result in more
> errore showing up next?

There is a whole number of small problems such as this one but as far
as I look at it all where only simple.

  Ralf