From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964807AbWFHI7d (ORCPT ); Thu, 8 Jun 2006 04:59:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751296AbWFHI7d (ORCPT ); Thu, 8 Jun 2006 04:59:33 -0400 Received: from gw.openss7.com ([142.179.199.224]:38079 "EHLO gw.openss7.com") by vger.kernel.org with ESMTP id S1751298AbWFHI7c (ORCPT ); Thu, 8 Jun 2006 04:59:32 -0400 Date: Thu, 8 Jun 2006 02:59:30 -0600 From: "Brian F. G. Bidulock" To: Andi Kleen Cc: Andrew Morton , adilger@clusterfs.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] use unlikely() for current_kernel_time() loop Message-ID: <20060608025930.A15559@openss7.org> Reply-To: bidulock@openss7.org Mail-Followup-To: Andi Kleen , Andrew Morton , adilger@clusterfs.com, linux-kernel@vger.kernel.org References: <20060607173642.GA6378@schatzie.adilger.int> <200606080851.20232.ak@suse.de> <20060608010004.A12202@openss7.org> <200606080907.26350.ak@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200606080907.26350.ak@suse.de>; from ak@suse.de on Thu, Jun 08, 2006 at 09:07:26AM +0200 Organization: http://www.openss7.org/ Dsn-Notification-To: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Andi, On Thu, 08 Jun 2006, Andi Kleen wrote: > > > > Originally because it made assembly too unreadable. Later it was discovered > > > it produces smaller code too. > > > Another quick check on Intel 630. w/o -fno-reorder-blocks: code increased 2% in size; performance increased 2% per hyperthread; code still as readable with objdump -S -d. Rather marginal one way or the other.