Re: [PATCH] readahead: initial method - expected read size - fix fastcall

Andrew Morton
2006-06-04T09:07:49Z

On Sun, 4 Jun 2006 15:34:15 +0800
Fengguang Wu <wfg@mail.ustc.edu.cn> wrote:

> Remove 'fastcall' directive for function readahead_close().
>
> It has drawn concerns from Andrew Morton.

Well. I think fastcall is ugly and vaguely silly. Now if we has a
really_really_fastcall then I'd like to use that!

> Now I have some benchmarks
> on it, and proved it as a _false_ optimization.

Sorry, I don't believe this will be measurable (and with CONFIG_REGPARM
it'll be a no-op).

But I'm always glad to see a fastcall disappear ;)