* Fix Compilation error for UM Linux
@ 2006-06-08 15:04 Suzuki
2006-06-08 17:46 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Suzuki @ 2006-06-08 15:04 UTC (permalink / raw)
To: lkml; +Cc: akpm
Hi,
This patch fixes the compilation error for UM Linux with linux-2.6.17-rc5.
It complains of using (void *) in arithmetic.
Thanks.
Suzuki K P
Linux Technology Center,
IBM Software Labs.
* Fix the compilation error for um-linux.
Signed Off by: Suzuki K P <suzuki@in.ibm.com>
--- arch/um/include/mem.h 2006-05-25 01:45:04.000000000 -0700
+++ arch/um/include/mem.h~fix_compilation_error 2006-06-08
07:46:21.000000000 -0700
@@ -22,7 +22,7 @@ static inline unsigned long to_phys(void
static inline void *to_virt(unsigned long phys)
{
- return((void *) uml_physmem + phys);
+ return (void *) (uml_physmem + phys);
}
#endif
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fix Compilation error for UM Linux
2006-06-08 15:04 Fix Compilation error for UM Linux Suzuki
@ 2006-06-08 17:46 ` Andrew Morton
2006-06-09 0:22 ` Jeff Dike
2006-06-09 5:11 ` Suzuki
0 siblings, 2 replies; 4+ messages in thread
From: Andrew Morton @ 2006-06-08 17:46 UTC (permalink / raw)
To: Suzuki; +Cc: linux-kernel
On Thu, 08 Jun 2006 20:34:08 +0530
Suzuki <suzuki@in.ibm.com> wrote:
> Hi,
>
> This patch fixes the compilation error for UM Linux with linux-2.6.17-rc5.
>
> It complains of using (void *) in arithmetic.
Really? We often do arithmetic on void*. Are you using gcc, with standard
kbuild and standard compiler options?
> Thanks.
>
> Suzuki K P
> Linux Technology Center,
> IBM Software Labs.
>
>
>
> * Fix the compilation error for um-linux.
>
> Signed Off by: Suzuki K P <suzuki@in.ibm.com>
"Signed-off-by:", please.
> --- arch/um/include/mem.h 2006-05-25 01:45:04.000000000 -0700
> +++ arch/um/include/mem.h~fix_compilation_error 2006-06-08
> 07:46:21.000000000 -0700
> @@ -22,7 +22,7 @@ static inline unsigned long to_phys(void
>
> static inline void *to_virt(unsigned long phys)
> {
> - return((void *) uml_physmem + phys);
> + return (void *) (uml_physmem + phys);
> }
>
> #endif
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fix Compilation error for UM Linux
2006-06-08 17:46 ` Andrew Morton
@ 2006-06-09 0:22 ` Jeff Dike
2006-06-09 5:11 ` Suzuki
1 sibling, 0 replies; 4+ messages in thread
From: Jeff Dike @ 2006-06-09 0:22 UTC (permalink / raw)
To: Andrew Morton; +Cc: Suzuki, linux-kernel
On Thu, Jun 08, 2006 at 10:46:55AM -0700, Andrew Morton wrote:
> Really? We often do arithmetic on void*. Are you using gcc, with standard
> kbuild and standard compiler options?
I've never seen any gcc complaints from that piece of code, so I'm
wondering the same thing.
Jeff
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: Fix Compilation error for UM Linux
2006-06-08 17:46 ` Andrew Morton
2006-06-09 0:22 ` Jeff Dike
@ 2006-06-09 5:11 ` Suzuki
1 sibling, 0 replies; 4+ messages in thread
From: Suzuki @ 2006-06-09 5:11 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
Andrew Morton wrote:
> On Thu, 08 Jun 2006 20:34:08 +0530
> Suzuki <suzuki@in.ibm.com> wrote:
>
>
>>Hi,
>>
>>This patch fixes the compilation error for UM Linux with linux-2.6.17-rc5.
>>
>>It complains of using (void *) in arithmetic.
>
>
> Really? We often do arithmetic on void*. Are you using gcc, with standard
> kbuild and standard compiler options?
Ah ! I was using g++ since the kernel had some C++ code in it. Sorry for
the same.
>
>
>>Thanks.
>>
>>Suzuki K P
>>Linux Technology Center,
>>IBM Software Labs.
>>
>>
>>
>>* Fix the compilation error for um-linux.
>>
>>Signed Off by: Suzuki K P <suzuki@in.ibm.com>
>
>
> "Signed-off-by:", please.
Sorry ! Will take care of it from now onwards.
Thanks,
Suzuki
>
>
>>--- arch/um/include/mem.h 2006-05-25 01:45:04.000000000 -0700
>>+++ arch/um/include/mem.h~fix_compilation_error 2006-06-08
>>07:46:21.000000000 -0700
>>@@ -22,7 +22,7 @@ static inline unsigned long to_phys(void
>>
>> static inline void *to_virt(unsigned long phys)
>> {
>>- return((void *) uml_physmem + phys);
>>+ return (void *) (uml_physmem + phys);
>> }
>>
>> #endif
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-06-09 5:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-08 15:04 Fix Compilation error for UM Linux Suzuki
2006-06-08 17:46 ` Andrew Morton
2006-06-09 0:22 ` Jeff Dike
2006-06-09 5:11 ` Suzuki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox