Re: [PATCH 4/4] Twofish cipher - x86_64 assembler

[linux@horizon.com]

> You can't use the 8bit high register with rex prefix registers ( r8+
> and any 64bit register). I guess this could be fixed be moving the crypto
> ctx or the output adress to a rex register and have %esi or %edi as temp
> register for the sbox-index. Somehow i never considered %esi or %edi as
> a possible target for the 8bit high operation and was convinced the only
> way to avoid using 4 * 8bit rotates was using temporary registers.

Oh, yeah!  Sorry about that.  You're quite right, but you're also
quite right that it's fixable.

I'd have to refresh my memory of the whole REX prefix business to figure
out how to minimize the code size.  I've forgotten the details.


Anyway, I'm glad to have been of some help.