From: Pavel Machek <pavel@ucw.cz>
To: Adam Belay <abelay@novell.com>
Cc: Greg KH <greg@kroah.com>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 4/9] PCI PM: save and restore configuration state correctly
Date: Sat, 10 Jun 2006 13:34:12 +0000 [thread overview]
Message-ID: <20060610133412.GA4950@ucw.cz> (raw)
In-Reply-To: <1149497166.7831.158.camel@localhost.localdomain>
Hi!
> This patch updates pci_save_state() and pci_restore_state() to be more
> in line with the PCI PM specification. Specifically, read-only
> registers are no longer saved, BIST is never touched, and the command
> register is handled more carefully. A new data structure "struct
> pci_dev_config" is created to store any context that might need to be
> saved before entering a higher power state.
>
> The configuration space cache is now obsolete and no longer needed for
> PCI PM. However, this patch does not remove it as it is still
> referenced by the PCI configuration space access restriction code. As
> an unexpected bonus, this patch also fixes a possible memory leak;
> drivers/pci/access.c wasn't expecting the MSI code in pci_save_state().
This should solve problems for people that use 'backwards' PCI space
restoring these days. Thanks, nice!
Pavel
--
Thanks for all the (sleeping) penguins.
prev parent reply other threads:[~2006-06-13 12:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-05 8:46 [PATCH 4/9] PCI PM: save and restore configuration state correctly Adam Belay
2006-06-10 13:34 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060610133412.GA4950@ucw.cz \
--to=pavel@ucw.cz \
--cc=abelay@novell.com \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox