From: Christoph Hellwig <hch@infradead.org>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Jeff Garzik <jeff@garzik.org>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
akpm@osdl.org, promise_linux@promise.com
Subject: Re: [PATCH] Promise 'stex' driver
Date: Sat, 10 Jun 2006 17:34:20 +0100 [thread overview]
Message-ID: <20060610163420.GA23699@infradead.org> (raw)
In-Reply-To: <1149956952.3335.22.camel@mulgrave.il.steeleye.com>
On Sat, Jun 10, 2006 at 11:29:12AM -0500, James Bottomley wrote:
> On Sat, 2006-06-10 at 17:10 +0100, Christoph Hellwig wrote:
> > The driver is not for scsi hardware. Please implement it as block
> > driver.
>
> Actually, I'm afraid it is ... look at the mailbox path ... it's one of
> these increasingly prevalent raid HBAs that speaks SCSI at the firmware
> level. Most commands are direct passthroughs, only INQUIRY and
> MODE_SENSE are actually emulated in the driver.
Oops, you're right. It emulates READ/WRITE6 at the top of the queuecommand
routine which made me thing it'll emulate more below.
So removing the READ/WRITE6 emulation and setting the flag so the midlayer
only uses READ/WRITE10+ is on top of the TODO list. Right after that is
using the scsi_kmap_atomic_sg/scsi_kunmap_atomic_sg for the remaining
emulated commands. More comments later.
next prev parent reply other threads:[~2006-06-10 16:34 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-10 16:08 [PATCH] Promise 'stex' driver Jeff Garzik
2006-06-10 16:10 ` Christoph Hellwig
2006-06-10 16:29 ` James Bottomley
2006-06-10 16:34 ` Christoph Hellwig [this message]
2006-06-10 16:50 ` Jeff Garzik
2006-06-10 17:10 ` Christoph Hellwig
2006-06-10 16:30 ` Jeff Garzik
2006-06-10 17:06 ` Christoph Hellwig
2006-06-10 17:37 ` Jeff Garzik
2006-06-10 18:22 ` James Bottomley
2006-06-10 18:43 ` Jeff Garzik
2006-06-10 22:28 ` Jeff Garzik
2006-06-10 17:47 ` Alexey Dobriyan
-- strict thread matches above, loose matches on Subject: below --
2006-07-19 15:07 Ed Lin
2006-07-20 21:27 ` Jeff Garzik
2006-07-20 23:55 ` James Bottomley
2006-07-21 0:16 ` Jeff Garzik
2006-07-21 1:07 ` Jens Axboe
2006-07-21 1:25 ` Jeff Garzik
2006-07-21 1:38 ` Jens Axboe
2006-07-21 2:10 ` Jeff Garzik
2006-07-21 2:36 ` Jens Axboe
2006-07-21 3:01 ` Jeff Garzik
2006-07-21 3:18 ` Jens Axboe
2006-07-21 3:52 ` Jeff Garzik
2006-07-21 12:13 ` Jens Axboe
2006-07-23 19:45 ` hch
2006-07-23 20:21 ` Jeff Garzik
2006-07-23 19:44 ` hch
2006-07-21 1:06 ` Jens Axboe
[not found] <NONAMEBFJ3sl3xbYiMC000000d4@nonameb.ptu.promise.com>
2006-07-25 9:26 ` hch
2006-07-26 1:20 ` Alan Cox
2006-07-25 17:30 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060610163420.GA23699@infradead.org \
--to=hch@infradead.org \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=promise_linux@promise.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox