From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161015AbWFJUiU (ORCPT ); Sat, 10 Jun 2006 16:38:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161011AbWFJUiU (ORCPT ); Sat, 10 Jun 2006 16:38:20 -0400 Received: from pasmtpb.tele.dk ([80.160.77.98]:16772 "EHLO pasmtp.tele.dk") by vger.kernel.org with ESMTP id S1030508AbWFJUiT (ORCPT ); Sat, 10 Jun 2006 16:38:19 -0400 Date: Sat, 10 Jun 2006 22:38:00 +0200 From: Sam Ravnborg To: "Randy.Dunlap" Cc: Mikael Pettersson , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, jgarzik , akpm Subject: Re: [PATCH] [2.6.17-rc6] Section mismatch in drivers/net/ne.o during modpost Message-ID: <20060610203800.GC9502@mars.ravnborg.org> References: <200606101211.k5ACBgtl029545@harpo.it.uu.se> <20060610121335.447e19f2.rdunlap@xenotime.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060610121335.447e19f2.rdunlap@xenotime.net> User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > > > > Not sure how serious this is; the driver seems to work fine later on. > > Doesn't look serious. init_module() is not __init, but it calls > some __init functions and touches some __initdata. This is the typical case with inconsistent tagging. > BTW, I would be happy to see some consistent results from modpost > section checking. I don't see all of these warnings (I see only 1) > when using gcc 3.3.6. What gcc version are you using? > Does that matter? (not directed at anyone in particular) I did not see anyone of them - strange. I did not dig into it, but objdump -rR ne.o should tell the number of mismatches with soem carefull checking. > --- linux-2617-rc6.orig/drivers/net/ne.c > +++ linux-2617-rc6/drivers/net/ne.c > @@ -829,7 +829,7 @@ that the ne2k probe is the last 8390 bas > is at boot) and so the probe will get confused by any other 8390 cards. > ISA device autoprobes on a running machine are not recommended anyway. */ > > -int init_module(void) > +int __init init_module(void) > { > int this_dev, found = 0; When you anyway touches the driver I suggest to name the function _init, _cleanup and use module_init(), module_cleanup(). Sam