Re: 2.6.16-rc6-mm2

Christoph Lameter
2006-06-10T18:36:06Z

On Sat, 10 Jun 2006, Michal Piotrowski wrote:

> And I get this error
> /usr/src/linux-mm/mm/page_alloc.c: In function 'vm_events_fold_cpu':
> /usr/src/linux-mm/mm/page_alloc.c:2885: error: incompatible type for
> argument 2 of 'count_vm_events'
> /usr/src/linux-mm/mm/page_alloc.c:2886: error: invalid type argument of '->'
> make[2]: *** [mm/page_alloc.o] B??d 1
> make[1]: *** [mm] B??d 2
> make: *** [_all] B??d 2
>
> As I said - pain in the ass for people that aren't kernel hackers.

Hmmm. That is hotplug which I cannot enable on ia64. I checked this by
moving the #ifdef CONFIG_HOTPLUG

Index: linux-2.6.17-rc6-mm2/mm/page_alloc.c
===================================================================
--- linux-2.6.17-rc6-mm2.orig/mm/page_alloc.c 2006-06-10 11:30:44.560354535 -0700
+++ linux-2.6.17-rc6-mm2/mm/page_alloc.c 2006-06-10 11:34:22.213840263 -0700
@@ -2881,8 +2881,8 @@ static void vm_events_fold_cpu(int cpu)
int i;

for (i = 0; i < NR_VM_EVENT_ITEMS; i++) {
- count_vm_events(i, fold_state->event[i]);
- local_set(fold_state->event[i], 0);
+ count_vm_events(i, local_read(&fold_state->event[i]));
+ local_set(&fold_state->event[i], 0);
}
}