Re: 2.6.16-rc6-mm2

Michal Piotrowski
2006-06-12T13:50:29Z

Hi Ingo,

On 12/06/06, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Christoph Lameter <clameter@sgi.com> wrote:
>
> > Sorry that patch was still against mm1. Here is a fixed up version
> > that applies cleanly against mm2:
>
> i have applied both patches you sent in this thread but it still
> triggers tons of messages:
>
> printk: 104 messages suppressed.
> BUG: using smp_processor_id() in preemptible [00000001] code: distccd/9263
> caller is __handle_mm_fault+0x58/0xd70
> [<c0105d6f>] show_trace+0xd/0x10
> [<c0105d89>] dump_stack+0x17/0x1a
> [<c0585ab4>] debug_smp_processor_id+0x88/0xa0
> [<c016eb63>] __handle_mm_fault+0x58/0xd70
> [<c110ff1c>] do_page_fault+0x2e5/0x672
> [<c0104a69>] error_code+0x39/0x40
> [<c110eade>] __kprobes_text_start+0x6/0x14
>
> trying to fix it i realized that i'd have to touch tons of
> architectures, which all duplicate this piece of code:
>
> /* Use these for per-cpu local_t variables: on some archs they are
> * much more efficient than these naive implementations. Note they take
> * a variable, not an address.
> */
> #define cpu_local_read(v) local_read(&__get_cpu_var(v))
> #define cpu_local_set(v, i) local_set(&__get_cpu_var(v), (i))
> #define cpu_local_inc(v) local_inc(&__get_cpu_var(v))
> #define cpu_local_dec(v) local_dec(&__get_cpu_var(v))
> #define cpu_local_add(i, v) local_add((i), &__get_cpu_var(v))
> #define cpu_local_sub(i, v) local_sub((i), &__get_cpu_var(v))
>
> #define __cpu_local_inc(v) cpu_local_inc(v)
> #define __cpu_local_dec(v) cpu_local_dec(v)
> #define __cpu_local_add(i, v) cpu_local_add((i), (v))
> #define __cpu_local_sub(i, v) cpu_local_sub((i), (v))
>
> that code must all be consolidated into a header in asm-generic, so that
> the per-arch file only implements _truly_ per-arch logic.

I just tried your latest lockdep-combo-2.6.17-rc6-mm2 patch, and I
get many warnings

WARNING: /lib/modules/2.6.17-rc6-mm2-lockdep/kernel/sound/core/snd-pcm.ko
needs unknown symbol down_write
WARNING: /lib/modules/2.6.17-rc6-mm2-lockdep/kernel/sound/core/snd-pcm.ko
needs unknown symbol up_write
WARNING: /lib/modules/2.6.17-rc6-mm2-lockdep/kernel/sound/core/snd-pcm.ko
needs unknown symbol down_read
WARNING: /lib/modules/2.6.17-rc6-mm2-lockdep/kernel/sound/core/snd-pcm.ko
needs unknown symbol up_read
WARNING: /lib/modules/2.6.17-rc6-mm2-lockdep/kernel/sound/core/oss/snd-mixer-oss.ko
needs unknown symbol down_read
WARNING: /lib/modules/2.6.17-rc6-mm2-lockdep/kernel/sound/core/oss/snd-mixer-oss.ko
needs unknown symbol up_read
WARNING: /lib/modules/2.6.17-rc6-mm2-lockdep/kernel/sound/core/seq/snd-seq.ko
needs unknown symbol down_write

>
> Ingo
>

Regards,
Michal

--
Michal K. K. Piotrowski
LTG - Linux Testers Group
(http://www.stardust.webpages.pl/ltg/wiki/)