Re: [PATCH] Fix for the PPTP hangs that have been reported

[Michael Buesch <mb@bu3sch.de>]

On Monday 12 June 2006 04:16, Paul Mackerras wrote:
> Signed-off-by: Paul Mackerras <paulus@samba.org>
> ---
> Linus & Andrew, I think this one is a 2.6.17 candidate.

What about 2.6.16-stable?
I just applied that patch to my server running 2.6.16.20.
Seems to be ok, but I did not stresstest it.

> It's a small 
> and harmless patch and it fixes a bug that has been annoying quite a
> few people, if the bugzilla reports are anything to go by.  I think it
> should solve bugzilla 6402 as well.
> 
> diff --git a/drivers/char/n_tty.c b/drivers/char/n_tty.c
> index ede365d..b9371d5 100644
> --- a/drivers/char/n_tty.c
> +++ b/drivers/char/n_tty.c
> @@ -1384,8 +1384,10 @@ do_it_again:
>  		 * longer than TTY_THRESHOLD_UNTHROTTLE in canonical mode,
>  		 * we won't get any more characters.
>  		 */
> -		if (n_tty_chars_in_buffer(tty) <= TTY_THRESHOLD_UNTHROTTLE)
> +		if (n_tty_chars_in_buffer(tty) <= TTY_THRESHOLD_UNTHROTTLE) {
> +			n_tty_set_room(tty);
>  			check_unthrottle(tty);
> +		}
>  
>  		if (b - buf >= minimum)
>  			break;

-- 
Greetings Michael.