Re: [PATCH 03/11] Task watchers: Refactor process events

Matt Helsley
2006-06-14T01:20:41Z

On Tue, 2006-06-13 at 19:43 -0500, Chase Venters wrote:
> On Tuesday 13 June 2006 18:54, Matt Helsley wrote:
>
> > + WARN_ON((which_id != PROC_EVENT_UID) && (which_id != PROC_EVENT_GID));
> > }
>
> How about WARN_ON(!(which_id & (PROC_EVENT_UID | PROC_EVENT_GID))) to save a
> cmp?
>
> Thanks,
> Chase

I think the compiler is capable of making such optimizations. I also
think what I have now is clearer to anyone skimming the code.

Cheers,
-Matt Helsley