Re: [Lse-tech] [PATCH 04/11] Task watchers: Make process events configurable as a module

Matt Helsley
2006-06-14T01:26:37Z

On Tue, 2006-06-13 at 19:54 -0500, Chase Venters wrote:
> On Tuesday 13 June 2006 18:54, Matt Helsley wrote:
>
> > +static void cn_proc_fini(void)
> > +{
> > + int err;
> > +
> > + err = unregister_task_watcher(&cn_proc_nb);
> > + if (err != 0)
> > + printk(KERN_WARNING
> > + "cn_proc failed to unregister its task notify block\n");
>
> How about if (err), or if (unregister_task_watcher(&cn_proc_nb))?

I don't see any worthwhile benefit to the former and I've seen feedback
that the latter is less readable.

> > + cn_del_callback(&cn_proc_event_id);
> > +}
> > +
> > module_init(cn_proc_init);
> > +module_exit(cn_proc_fini);
>
> Thanks,
> Chase