Re: [Lse-tech] [PATCH 08/11] Task watchers: Register profile as a task watcher

Matt Helsley
2006-06-14T01:24:48Z

On Tue, 2006-06-13 at 19:59 -0500, Chase Venters wrote:
> On Tuesday 13 June 2006 18:54, Matt Helsley wrote:
>
> > switch (type) {
> > - case PROFILE_TASK_EXIT:
> > - err = blocking_notifier_chain_register(
> > - &task_exit_notifier, n);
> > - break;
> > case PROFILE_MUNMAP:
> > err = blocking_notifier_chain_register(
> > &munmap_notifier, n);
> > break;
> > }
>
> if (type == PROFILE_MUNMAP)
>
> ?
>
> > @@ -140,14 +130,10 @@ int profile_event_register(enum profile_
> > int profile_event_unregister(enum profile_type type, struct notifier_block
> > * n) {
> > int err = -EINVAL;
> >
> > switch (type) {
> > - case PROFILE_TASK_EXIT:
> > - err = blocking_notifier_chain_unregister(
> > - &task_exit_notifier, n);
> > - break;
> > case PROFILE_MUNMAP:
> > err = blocking_notifier_chain_unregister(
> > &munmap_notifier, n);
> > break;
> > }
>
> Same...
>
> Thanks,
> Chase

Hmm. Perhaps I ought to get rid of the condition and enum entirely then
change the names of the functions to profile_mmmap() and
profile_munmap().

It really depends on what additional changes, if any, are expected
here. Since I don't have any plans to further modify profiling beyond
what I've outlined in these patches I'm not sure what the best course is
here.

Thanks,
-Matt Helsley