From: Pete Zaitcev <zaitcev@redhat.com>
To: "Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br>
Cc: rmk+lkml@arm.linux.org.uk, gregkh@suse.de,
alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net, zaitcev@redhat.com
Subject: Re: Serial-Core: USB-Serial port current issues.
Date: Wed, 14 Jun 2006 17:53:08 -0700 [thread overview]
Message-ID: <20060614175308.877cf6a0.zaitcev@redhat.com> (raw)
In-Reply-To: <20060614173824.60d1bc2e@doriath.conectiva>
On Wed, 14 Jun 2006 17:38:24 -0300, "Luiz Fernando N. Capitulino" <lcapitulino@mandriva.com.br> wrote:
> I think BUG_ON(in_interrupt()) does the job. I'll try it here, and
> if it doesn't trigger I'll submit a patch to Andrew only for
> testing porpuses (ie, not for mainline).
Luiz, you can't be serious! You have to do a review and write call paths
on a piece of paper or however you prefer to do it. Your testing is
extremely limited as we know, you don't even have a null-modem cable.
So if the patch does not trip in your testing it tells you absolutely
nothing. But even in context of AKPM's tree you can't rely on run-time
checks to pick this sort of things.
And putting a BUG in there is irresponsible too. It's such a critical
subsystem. Drop bytes or return zero modem lines, but do not bug out.
-- Pete
next prev parent reply other threads:[~2006-06-15 0:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-13 22:28 Serial-Core: USB-Serial port current issues Luiz Fernando N. Capitulino
2006-06-14 15:28 ` Russell King
2006-06-14 20:38 ` Luiz Fernando N. Capitulino
2006-06-15 0:53 ` Pete Zaitcev [this message]
2006-06-15 13:29 ` Luiz Fernando N. Capitulino
2006-06-15 16:07 ` Greg KH
2006-06-15 16:21 ` Luiz Fernando N. Capitulino
2006-06-20 19:11 ` Luiz Fernando N. Capitulino
2006-06-21 2:32 ` Pete Zaitcev
2006-06-21 16:35 ` Luiz Fernando N. Capitulino
2006-06-21 16:43 ` Russell King
2006-06-21 21:15 ` Luiz Fernando N. Capitulino
2006-06-22 8:29 ` Russell King
2006-06-23 17:28 ` Luiz Fernando N. Capitulino
2006-06-26 22:26 ` Greg KH
2006-06-27 0:49 ` Paul Fulghum
2006-07-04 19:42 ` Luiz Fernando N. Capitulino
2006-07-04 19:50 ` Pete Zaitcev
2006-07-04 20:36 ` Luiz Fernando N. Capitulino
2006-07-05 13:40 ` [linux-usb-devel] " Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060614175308.877cf6a0.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=gregkh@suse.de \
--cc=lcapitulino@mandriva.com.br \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox