public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: Andreas Schwab <schwab@suse.de>
Cc: Linus Torvalds <torvalds@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] affs_fill_super() %s abuses
Date: Thu, 15 Jun 2006 13:02:30 +0100	[thread overview]
Message-ID: <20060615120230.GP27946@ftp.linux.org.uk> (raw)
In-Reply-To: <jever2aayc.fsf@sykes.suse.de>

On Thu, Jun 15, 2006 at 01:56:59PM +0200, Andreas Schwab wrote:
> Al Viro <viro@ftp.linux.org.uk> writes:
> 
> > %s is valid only on NUL-terminated arrays, damnit!
> 
> Unless it specifies an approriate precision.

... and that precision does not exceed the size of array.  Here we have
AFFS_ROOT_TAIL(sb, root_bh)->disk_name[0] as precision and
AFFS_ROOT_TAIL(sb, root_bh)->disk_name + 1 as pointer.  Which is closer
to the end of object than 256 bytes.

  reply	other threads:[~2006-06-15 12:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-15 11:03 [PATCH] affs_fill_super() %s abuses Al Viro
2006-06-15 11:56 ` Andreas Schwab
2006-06-15 12:02   ` Al Viro [this message]
2006-06-15 12:31 ` Roman Zippel
2006-06-15 12:39   ` Al Viro
2006-06-15 12:40   ` Andreas Schwab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060615120230.GP27946@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwab@suse.de \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox