From: Al Viro <viro@ftp.linux.org.uk>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: Linus Torvalds <torvalds@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] affs_fill_super() %s abuses
Date: Thu, 15 Jun 2006 13:39:03 +0100 [thread overview]
Message-ID: <20060615123903.GR27946@ftp.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0606151427290.17704@scrub.home>
On Thu, Jun 15, 2006 at 02:31:05PM +0200, Roman Zippel wrote:
> > - printk(KERN_NOTICE "AFFS: Mounting volume \"%*s\": Type=%.3s\\%c, Blocksize=%d\n",
> > - AFFS_ROOT_TAIL(sb, root_bh)->disk_name[0],
> > - AFFS_ROOT_TAIL(sb, root_bh)->disk_name + 1,
> > - (char *)&chksum,((char *)&chksum)[3] + '0',blocksize);
> > + int len = AFFS_ROOT_TAIL(sb, root_bh)->disk_name[0];
> > + char name[32];
> > +
> > + if (len > 31)
> > + len = 31;
>
> You get the same effect by changing it above into "min(AFFS_ROOT_TAIL(sb,
> root_bh)->disk_name[0], 31)" and makes the copying unnecessary.
> BTW since this is only active with SF_VERBOSE, I don't think it's critical
> enough for 2.6.17 at this point.
Fine by me... I'd still prefer more explicit form (it's hardly a critical
path), but yes, that would do.
next prev parent reply other threads:[~2006-06-15 12:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-15 11:03 [PATCH] affs_fill_super() %s abuses Al Viro
2006-06-15 11:56 ` Andreas Schwab
2006-06-15 12:02 ` Al Viro
2006-06-15 12:31 ` Roman Zippel
2006-06-15 12:39 ` Al Viro [this message]
2006-06-15 12:40 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060615123903.GR27946@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox