From: Jens Axboe <axboe@suse.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix cdrom open
Date: Fri, 16 Jun 2006 07:45:32 +0200 [thread overview]
Message-ID: <20060616054531.GI3456@suse.de> (raw)
In-Reply-To: <20060616135631.146a24fe.sfr@canb.auug.org.au>
On Fri, Jun 16 2006, Stephen Rothwell wrote:
> Hi Jens,
>
> Some time ago the cdrom open routine was changed so that we call the
> driver's open routine before checking to see if it is read only. However,
> if we discovered that a read write open was not possible and the open
> flags required a writable open, we just returned -EROFS without calling
> the driver's release routine. This seems to work for most cdrom drivers,
> but breaks the Powerpc iSeries virtual cdrom rather badly. The following
> patch just inserts the release call in the error path.
>
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> It would be good is this could go into 2.6.17 as it affects the new distro
> kernels.
Looks good, I'll forward it for 2.6.17 inclusion.
--
Jens Axboe
prev parent reply other threads:[~2006-06-16 5:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-16 3:56 [PATCH] fix cdrom open Stephen Rothwell
2006-06-16 5:45 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060616054531.GI3456@suse.de \
--to=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox