From: Marcelo Tosatti <marcelo@kvack.org>
To: Willy Tarreau <w@1wt.eu>
Cc: Grant Coady <gcoady.lk@gmail.com>,
Michal Piotrowski <michal.k.k.piotrowski@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.33-rc1
Date: Sat, 17 Jun 2006 16:55:43 -0300 [thread overview]
Message-ID: <20060617195543.GA26972@dmt> (raw)
In-Reply-To: <20060617071000.GA23498@1wt.eu>
> > Hi Willy, this worked.
>
> OK Fine. However, I don't understand. From you oops, it looks like
> dentry->d_inode suddenly gets NULL before calling this line :
>
> double_up(&dir->i_zombie, &dentry->d_inode->i_zombie);
>
> I'm wondering if the unlink(dir, dentry) above can produce this. If this
> is the case, the Vadim's fix is terribly broken. I also think that in
> vfs_link(), we can encounter the same problem that Marcelo had to fix,
> because double_down() is performed without prior checking that
> old_dentry->d_inode is valid.
Right, it should just check for the NULL case.
> Marcelo, do you have Vadim's email somewhere ? I think he should help us
> on this otherwise it would be better to revert his fix, as it has introduced
> lots of sensible changes in the error path.
The patch fixes a serious SMP race.
>
> > Grant.
>
> Thanks for the tests, Grant.
> Willy
next prev parent reply other threads:[~2006-06-18 13:37 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-16 18:14 Linux 2.4.33-rc1 Marcelo Tosatti
2006-06-16 22:21 ` Grant Coady
2006-06-16 22:38 ` Michal Piotrowski
2006-06-16 23:24 ` Grant Coady
2006-06-17 5:13 ` Willy Tarreau
2006-06-17 6:24 ` Grant Coady
2006-06-17 7:10 ` Willy Tarreau
2006-06-17 17:15 ` Need to format twice /dev/ramX with reiserfs to be able to mount it ? sebastien cabaniols
2006-06-17 18:14 ` Bernd Eckenfels
2006-06-17 18:37 ` sebastien cabaniols
2006-06-17 19:55 ` Marcelo Tosatti [this message]
2006-06-18 13:37 ` Linux 2.4.33-rc1 Marcelo Tosatti
2006-06-18 22:25 ` Grant Coady
2006-06-18 22:37 ` Willy Tarreau
2006-06-18 23:07 ` Grant Coady
2006-06-19 4:01 ` Willy Tarreau
2006-06-19 5:03 ` Grant Coady
2006-06-19 8:06 ` Willy Tarreau
2006-06-19 8:53 ` Grant Coady
2006-06-19 9:08 ` Willy Tarreau
2006-06-19 9:12 ` Grant Coady
2006-06-19 9:24 ` Willy Tarreau
2006-06-19 10:27 ` Grant Coady
2006-06-19 10:31 ` Willy Tarreau
2006-06-19 20:11 ` Grant Coady
2006-06-19 20:20 ` Willy Tarreau
2006-06-19 22:04 ` Marcelo Tosatti
2006-06-19 23:00 ` Willy Tarreau
2006-06-19 23:45 ` Marcelo Tosatti
2006-06-20 22:23 ` Willy Tarreau
2006-06-21 1:09 ` Grant Coady
2006-06-21 4:05 ` Willy Tarreau
2006-06-21 13:50 ` Marcelo Tosatti
2006-06-21 20:26 ` Willy Tarreau
2006-06-18 22:33 ` Grant Coady
2006-06-18 22:40 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060617195543.GA26972@dmt \
--to=marcelo@kvack.org \
--cc=gcoady.lk@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox