From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964858AbWFSTdg (ORCPT ); Mon, 19 Jun 2006 15:33:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964860AbWFSTdg (ORCPT ); Mon, 19 Jun 2006 15:33:36 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:10702 "EHLO ZenIV.linux.org.uk") by vger.kernel.org with ESMTP id S964858AbWFSTdf (ORCPT ); Mon, 19 Jun 2006 15:33:35 -0400 Date: Mon, 19 Jun 2006 20:33:35 +0100 From: Al Viro To: Theodore Tso Cc: linux-kernel@vger.kernel.org Subject: Re: [RFC] [PATCH 6/8] inode-diet: Move i_cindex from struct inode to struct file Message-ID: <20060619193335.GL27946@ftp.linux.org.uk> References: <20060619152003.830437000@candygram.thunk.org> <20060619153110.075342000@candygram.thunk.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060619153110.075342000@candygram.thunk.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 19, 2006 at 11:20:09AM -0400, Theodore Tso wrote: > inode.i_cindex isn't initialized until the character device is opened > anyway, and there are far more struct inodes in memory than there are > struct file. So move the cindex field to file.f_cindex, and change > the one(!) user of cindex to use file pointer, which is in fact simpler. NAK. Please, take it to the union into cdev part.