From: Theodore Tso <tytso@mit.edu>
To: Christoph Hellwig <hch@infradead.org>,
linux-kernel@vger.kernel.org, linux390@de.ibm.com
Subject: Re: [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private
Date: Mon, 19 Jun 2006 15:37:06 -0400 [thread overview]
Message-ID: <20060619193706.GA16594@thunk.org> (raw)
In-Reply-To: <20060619190921.GA16959@infradead.org>
On Mon, Jun 19, 2006 at 08:09:22PM +0100, Christoph Hellwig wrote:
> > Index: linux-2.6.17/arch/s390/kernel/debug.c
> > ===================================================================
> > --- linux-2.6.17.orig/arch/s390/kernel/debug.c 2006-06-18 18:58:51.000000000 -0400
> > +++ linux-2.6.17/arch/s390/kernel/debug.c 2006-06-18 18:58:55.000000000 -0400
> > @@ -604,7 +604,7 @@
> > debug_info_t *debug_info, *debug_info_snapshot;
> >
> > down(&debug_lock);
> > - debug_info = (struct debug_info*)file->f_dentry->d_inode->u.generic_ip;
> > + debug_info = (struct debug_info*)file->f_dentry->d_inode->i_private;
>
> is this actually okay? who owns the private data in debugfs inodes?
debugfs allows the caller of debugfs_create_file() to pass in private
data. So this in fact the intended way it's supposed to work AFAIK.
The s/390 debug facility passed in a struct debug_info * in
debug_register_view()'s call to debugfs_create_file, and it pulls it
out again in debug_open() (in the above referenced patch).
- Ted
next prev parent reply other threads:[~2006-06-19 19:37 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-19 15:20 [RFC] [PATCH 0/8] Inode slimming Theodore Tso
2006-06-19 15:20 ` [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private Theodore Tso
2006-06-19 17:17 ` Jan Engelhardt
2006-06-19 19:09 ` Christoph Hellwig
2006-06-19 19:37 ` Theodore Tso [this message]
2006-06-20 9:43 ` Steven Whitehouse
2006-06-20 11:45 ` Arnd Bergmann
2006-06-20 12:34 ` Steven Whitehouse
2006-06-20 13:53 ` Arnd Bergmann
2006-06-20 15:01 ` Brian F. G. Bidulock
2006-06-20 15:04 ` Brian F. G. Bidulock
2006-06-20 12:29 ` Theodore Tso
2006-06-19 15:20 ` [RFC] [PATCH 2/8] inode-diet: Move i_pipe into a union Theodore Tso
2006-06-19 17:19 ` Jan Engelhardt
2006-06-19 19:06 ` Theodore Tso
2006-06-20 15:23 ` Brian F. G. Bidulock
2006-06-21 1:45 ` Theodore Tso
2006-06-22 9:03 ` Brian F. G. Bidulock
2006-06-19 15:20 ` [RFC] [PATCH 3/8] inode-diet: Move i_bdev " Theodore Tso
2006-06-19 15:20 ` [RFC] [PATCH 4/8] inode-diet: Move i_cdev " Theodore Tso
2006-06-19 17:20 ` Jan Engelhardt
2006-06-19 15:20 ` [RFC] [PATCH 5/8] inode-diet: Eliminate i_blksize and use a per-superblock default Theodore Tso
2006-06-19 15:49 ` Avi Kivity
2006-06-19 16:55 ` Theodore Tso
2006-06-19 15:58 ` Christoph Hellwig
2006-06-19 16:16 ` Joel Becker
2006-06-19 17:20 ` Theodore Tso
2006-06-19 18:55 ` Christoph Hellwig
2006-06-19 22:13 ` Mark Fasheh
2006-06-21 19:41 ` Nate Diller
2006-06-19 17:03 ` Theodore Tso
2006-06-19 18:56 ` Christoph Hellwig
2006-06-19 16:01 ` Joel Becker
2006-06-19 17:06 ` Theodore Tso
2006-06-19 21:45 ` Joel Becker
2006-06-19 22:14 ` Mark Fasheh
2006-06-19 15:20 ` [RFC] [PATCH 6/8] inode-diet: Move i_cindex from struct inode to struct file Theodore Tso
2006-06-19 19:33 ` Al Viro
2006-06-19 19:37 ` Al Viro
2006-06-19 20:58 ` Theodore Tso
2006-06-19 21:51 ` Stefan Richter
2006-06-19 15:20 ` [RFC] [PATCH 7/8] inode-diet: Use a union for i_blocks and i_size, i_rdev and i_devices Theodore Tso
2006-06-19 15:20 ` [RFC] [PATCH 8/8] inode-diet: Fix size of i_blkbits, i_version, and i_dnotify_mask Theodore Tso
2006-06-19 16:54 ` [RFC] [PATCH 0/8] Inode slimming Christoph Lameter
2006-06-19 19:09 ` Theodore Tso
-- strict thread matches above, loose matches on Subject: below --
2006-06-21 12:51 [RFC] [PATCH 0/8] Inode diet v2 Theodore Tso
2006-06-21 12:51 ` [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private Theodore Tso
2006-06-21 13:23 ` Jan Engelhardt
2006-06-21 14:44 ` Brian F. G. Bidulock
2006-06-21 15:37 ` Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060619193706.GA16594@thunk.org \
--to=tytso@mit.edu \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux390@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox