Re: [RFC] [PATCH 5/8] inode-diet: Eliminate i_blksize and use a per-superblock default

Mark Fasheh
2006-06-19T22:14:26Z

On Mon, Jun 19, 2006 at 01:06:27PM -0400, Theodore Tso wrote:
> How strongly do you feel about reporting stat.st_blksize out to be the
> clustersize? Keeping in mind that if you report a value which is too
> big, /bin/cp will start coredumping....
Any idea on what constitutes "too big"? We could always cap things at some
reasonable maximum. AFAIR, the reason it's set to clustersize these days is
because it actually made a performance impact on large file operations -
backing up a data base file, for example.

> If I take Christoph's suggestion of simply removing sb->s_blksize
> altogether, and forcing filesystems that want to return a non-default
> value for stat.st_blksize to supply their own filesystem-specific
> getattr, will you mind terribly?
No, I don't mind really - it's a minor bit of code and it'll save us all
some space on the super block structure. I assume we can just continue to
follow Christoph's suggestion in ocfs2_getattr().
--Mark

--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com