Re: [RFC] [PATCH 5/8] inode-diet: Eliminate i_blksize and use a per-superblock default

Joel Becker
2006-06-19T16:02:05Z

On Mon, Jun 19, 2006 at 11:20:08AM -0400, Theodore Tso wrote:
> Index: linux-2.6.17/fs/ocfs2/super.c
> ===================================================================
> --- linux-2.6.17.orig/fs/ocfs2/super.c 2006-06-18 19:37:14.000000000 -0400
> +++ linux-2.6.17/fs/ocfs2/super.c 2006-06-18 19:53:54.000000000 -0400
> @@ -1390,7 +1390,7 @@
> /* get some pseudo constants for clustersize bits */
> osb->s_clustersize_bits =
> le32_to_cpu(di->id2.i_super.s_clustersize_bits);
> - osb->s_clustersize = 1 << osb->s_clustersize_bits;
> + osb->s_blksize = osb->s_clustersize = 1 << osb->s_clustersize_bits;

I assume you meant sb->s_blksize. osb is a private structure
hanging off of sb->s_fs_info.
I have to say, having sb->s_blocksize and sb->s_blksize might be
a little confusing.

Joel

--

"Heav'n hath no rage like love to hatred turn'd, nor Hell a fury,
like a woman scorn'd."
- William Congreve

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127