Re: [RFC] [PATCH 5/8] inode-diet: Eliminate i_blksize and use a per-superblock default

Theodore Tso
2006-06-19T17:06:31Z

On Mon, Jun 19, 2006 at 09:01:46AM -0700, Joel Becker wrote:
>
> I assume you meant sb->s_blksize. osb is a private structure
> hanging off of sb->s_fs_info.

Yep, mea culpa.

> I have to say, having sb->s_blocksize and sb->s_blksize might be
> a little confusing.

How strongly do you feel about reporting stat.st_blksize out to be the
clustersize? Keeping in mind that if you report a value which is too
big, /bin/cp will start coredumping....

If I take Christoph's suggestion of simply removing sb->s_blksize
altogether, and forcing filesystems that want to return a non-default
value for stat.st_blksize to supply their own filesystem-specific
getattr, will you mind terribly?

- Ted