Re: [RFC] [PATCH 5/8] inode-diet: Eliminate i_blksize and use a per-superblock default

Mark Fasheh
2006-06-19T22:13:21Z

On Mon, Jun 19, 2006 at 07:55:55PM +0100, Christoph Hellwig wrote:
> And to answer Joel's statment of these three two already implement their
> own ->getattr. Also it doesn't mean a filesystem has to completely
> reimplement it, they just have to override it by reusing generic_fillattr,
> e.g.
And actually, that's what we do in ocfs2_getattr() today already:

generic_fillattr(inode, stat);

/* We set the blksize from the cluster size for performance */
stat->blksize = osb->s_clustersize;

Thanks,
--Mark
--
Mark Fasheh
Senior Software Developer, Oracle
mark.fasheh@oracle.com