Re: [RFC] [PATCH 4/8] inode-diet: Move i_cdev into a union

Jan Engelhardt
2006-06-19T17:20:45Z

>===================================================================
>--- linux-2.6.17.orig/fs/file_table.c 2006-06-18 19:37:14.000000000 -0400
>+++ linux-2.6.17/fs/file_table.c 2006-06-18 19:50:56.000000000 -0400
>@@ -170,7 +170,7 @@
> if (file->f_op && file->f_op->release)
> file->f_op->release(inode, file);
> security_file_free(file);
>- if (unlikely(inode->i_cdev != NULL))
>+ if (unlikely(S_ISCHR(inode->i_mode) && (inode->i_cdev != NULL)))

Am I allowed to be nitpicky? If so, drop the () around inode->i_cdev !=
NULL. :)

Jan Engelhardt
--