Re: [RFC] [PATCH 5/8] inode-diet: Eliminate i_blksize and use a per-superblock default

Theodore Tso
2006-06-19T16:55:22Z

On Mon, Jun 19, 2006 at 06:49:22PM +0300, Avi Kivity wrote:
>
> Isn't this a behavioral change? If a filesystem chooses to provide
> i_blksize via a getattr method, it will not show on nfs mounts.

There's actually a philosophical question hiding here over what's the
right thing to do with how st_blksize should be handled over NFS ---
st_blksize is supposed to be the "optimum I/O size"; the question is
what is the right answer that we report in both directions. For
example, it doesn't matter if we're exporting a Ultra Fast whiz-bang
cluster filesystem with a stripsize of 100 gigabytes. If wsize is
1024, it might be that we shouldn't be sending back an st_blksize
that's really big.

So I'm not pretending that what we have in the patch is the right
thing, only that I'm not entirely sure we were ever doing the right
thing here.

- Ted