From: Dave Jones <davej@redhat.com>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andreas Mohr <andi@rhlx01.fht-esslingen.de>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [patch] i386: halt the CPU on serious errors
Date: Tue, 20 Jun 2006 01:09:10 -0400 [thread overview]
Message-ID: <20060620050910.GA6091@redhat.com> (raw)
In-Reply-To: <200606200059_MC3-1-C2E8-8C46@compuserve.com>
On Tue, Jun 20, 2006 at 12:55:25AM -0400, Chuck Ebbert wrote:
> --- 2.6.17-32.orig/arch/i386/kernel/crash.c
> +++ 2.6.17-32/arch/i386/kernel/crash.c
> @@ -113,8 +113,8 @@ static int crash_nmi_callback(struct pt_
> disable_local_APIC();
> atomic_dec(&waiting_for_crash_ipi);
> /* Assume hlt works */
> - halt();
> - for(;;);
> + for (;;)
> + halt();
>
> return 1;
But we should never get past that first halt(), as interrupts are disabled.
> --- 2.6.17-32.orig/arch/i386/kernel/doublefault.c
> +++ 2.6.17-32/arch/i386/kernel/doublefault.c
> @@ -44,7 +44,8 @@ static void doublefault_fn(void)
> }
> }
>
> - for (;;) /* nothing */;
> + for (;;)
> + halt();
> }
This one would probably be better off as a cpu_relax()
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2006-06-20 5:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-20 4:55 [patch] i386: halt the CPU on serious errors Chuck Ebbert
2006-06-20 5:09 ` Dave Jones [this message]
2006-06-20 7:50 ` Andreas Mohr
2006-06-21 9:20 ` Andi Kleen
2006-06-21 9:26 ` Arjan van de Ven
-- strict thread matches above, loose matches on Subject: below --
2006-06-21 9:17 Chuck Ebbert
2006-06-21 9:17 Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060620050910.GA6091@redhat.com \
--to=davej@redhat.com \
--cc=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=andi@rhlx01.fht-esslingen.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox