From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751300AbWFTPBh (ORCPT ); Tue, 20 Jun 2006 11:01:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751298AbWFTPBh (ORCPT ); Tue, 20 Jun 2006 11:01:37 -0400 Received: from gw.openss7.com ([142.179.199.224]:55967 "EHLO gw.openss7.com") by vger.kernel.org with ESMTP id S1751291AbWFTPBg (ORCPT ); Tue, 20 Jun 2006 11:01:36 -0400 Date: Tue, 20 Jun 2006 09:01:35 -0600 From: "Brian F. G. Bidulock" To: Arnd Bergmann Cc: Steven Whitehouse , Theodore Tso , linux-kernel@vger.kernel.org Subject: Re: [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private Message-ID: <20060620090135.B10897@openss7.org> Reply-To: bidulock@openss7.org Mail-Followup-To: Arnd Bergmann , Steven Whitehouse , Theodore Tso , linux-kernel@vger.kernel.org References: <20060619152003.830437000@candygram.thunk.org> <200606201345.45332.arnd.bergmann@de.ibm.com> <1150806849.3856.1370.camel@quoit.chygwyn.com> <200606201553.23908.arnd.bergmann@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: <200606201553.23908.arnd.bergmann@de.ibm.com>; from arnd.bergmann@de.ibm.com on Tue, Jun 20, 2006 at 03:53:23PM +0200 Organization: http://www.openss7.org/ Dsn-Notification-To: Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Arnd, On Tue, 20 Jun 2006, Arnd Bergmann wrote: > > Alternatively, it might be possible to stuff i_private into the same > union as i_pipe, i_cdev and i_bdev. The rationale here being that > a file system implementing different file types already is complex > enough that you would normally want your own alloc_inode for a > derived struct. The simple file systems OTOH normally only support > regular files, and sometimes directories. Placing i_private and i_pipe in the same union will break FIFOs. Also, i_pipe should not be combined with i_cdev and i_bdev.