Re: [Ubuntu PATCH] cpufreq: fix powernow-k8 load bug

Pavel Machek
2006-06-23T10:57:37Z

Hi!

> Fix powernow-k8 doesn't load bug.
> Reference: https://launchpad.net/distros/ubuntu/+source/linux-source-2.6.15/+bug/35145
>
> http://www.kernel.org/git/?p=linux/kernel/git/bcollins/ubuntu-dapper.git;a=commitdiff;h=dce0ca36f2ae348f005735e9acd400d2c0954421
>
>
>
> ---
> arch/i386/kernel/cpu/cpufreq/powernow-k8.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2617-pv.orig/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
> +++ linux-2617-pv/arch/i386/kernel/cpu/cpufreq/powernow-k8.c
> @@ -1008,7 +1008,7 @@ static int __cpuinit powernowk8_cpu_init
> * an UP version, and is deprecated by AMD.
> */
>
> - if ((num_online_cpus() != 1) || (num_possible_cpus() != 1)) {
> + if ((num_online_cpus() != 1)) {
> printk(KERN_ERR PFX "MP systems not supported by PSB BIOS structure\n");
> kfree(data);
> return -ENODEV;
>

Seems wrong to me... what if I boot, then hotplug second cpu?
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms