public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Brian F. G. Bidulock" <bidulock@openss7.org>
To: Theodore Tso <tytso@thunk.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC] [PATCH 0/8] Inode diet v2
Date: Wed, 21 Jun 2006 08:42:17 -0600	[thread overview]
Message-ID: <20060621084217.B7834@openss7.org> (raw)
In-Reply-To: <20060621125146.508341000@candygram.thunk.org>; from tytso@thunk.org on Wed, Jun 21, 2006 at 08:51:46AM -0400

Theodore,

On Wed, 21 Jun 2006, Theodore Tso wrote:

> Unfortunately, since these structures are used by a large amount of
> kernel code, some of the patches are quite involved, and/or will
> require a lot of auditing and code review, for "only" 4 or 8 bytes at
> a time (maybe more on 64-bit platforms).  However, since there are
> many, many copies of struct inode all over the kernel, even a small
> reduction in size can have a large beneficial result, and as the old
> Chinese saying goes, a journey of thousand miles begins with a single
> step....

Can you grep inode_cache /proc/slabinfo to see whether you saved any
memory at all?

You need to save 48 bytes per inode to fit one more into a slab with
a 32 byte L1 cache slot; 120 bytes per inode, 64 byte L1 cache slot.
And that's just a generic inode_cache object.  Something that is really
used, like ext3_inode_cache or nfs_inode_cache is going to take more
doing.  Moving a field from the generic inode to the filesystem specific
inode acheives nothing.


  parent reply	other threads:[~2006-06-21 14:42 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-21 12:51 [RFC] [PATCH 0/8] Inode diet v2 Theodore Tso
2006-06-21 12:51 ` [RFC] [PATCH 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private Theodore Tso
2006-06-21 13:23   ` Jan Engelhardt
2006-06-21 14:44   ` Brian F. G. Bidulock
2006-06-21 15:37     ` Theodore Tso
2006-06-21 12:51 ` [RFC] [PATCH 2/8] inode-diet: Move i_pipe into a union Theodore Tso
2006-06-21 12:51 ` [RFC] [PATCH 3/8] inode-diet: Move i_bdev " Theodore Tso
2006-06-21 12:51 ` [RFC] [PATCH 4/8] inode-diet: Move i_cdev " Theodore Tso
2006-06-21 12:51 ` [RFC] [PATCH 5/8] inode-diet: Eliminate i_blksize and use a per-superblock default Theodore Tso
2006-06-21 12:51 ` [RFC] [PATCH 6/8] inode-diet: Move i_cindex from struct inode to struct file Theodore Tso
2006-06-21 12:51 ` [RFC] [PATCH 7/8] inode-diet: Use a union for i_blocks and i_size, i_rdev and i_devices Theodore Tso
2006-06-21 12:51 ` [RFC] [PATCH 8/8] inode-diet: Fix size of i_blkbits, i_version, and i_dnotify_mask Theodore Tso
     [not found]   ` <200606212335.00176.arnd@arndb.de>
2006-06-22  3:11     ` Theodore Tso
2006-06-21 14:42 ` Brian F. G. Bidulock [this message]
2006-06-21 15:31   ` [RFC] [PATCH 0/8] Inode diet v2 Nick Piggin
2006-06-21 16:06   ` Arjan van de Ven
2006-06-21 16:12     ` Brian F. G. Bidulock
2006-06-21 16:48   ` Theodore Tso

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060621084217.B7834@openss7.org \
    --to=bidulock@openss7.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@thunk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox