Re: 2.6.17-rc5-mm2 another compile error

[Adrian Bunk <bunk@stusta.de>]

On Thu, Jun 01, 2006 at 09:29:53AM -0700, Andrew Morton wrote:
> On Thu, 01 Jun 2006 13:42:35 +0200
> Helge Hafting <helge.hafting@aitel.hist.no> wrote:
> 
> >   CC      drivers/dma/ioatdma.o
> > drivers/dma/ioatdma.c: In function ‘ioat_init_module’:
> > drivers/dma/ioatdma.c:828: error: dereferencing pointer to incomplete type
> > make[2]: *** [drivers/dma/ioatdma.o] Error 1
> > make[1]: *** [drivers/dma] Error 2
> > make: *** [drivers] Error 2
> > 
> 
>         if (THIS_MODULE != NULL)
>                 THIS_MODULE->unsafe = 1;
> 
> Chris, this won't compile with CONFIG_MODULES=n.
> 
> If module unloading is unsafe (why?) then a suitable workaround would be to
> take an additional ref on the module (__module_get()) so that it cannot be
> unloaded.

This bug is still present in 2.6.17-mm1, and even worse it's now in 
Linus' tree.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed