public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Greg KH <gregkh@suse.de>
Cc: vgoyal@in.ibm.com, greg@kroah.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 64bit resources start end value fix
Date: Wed, 21 Jun 2006 14:01:25 -0700	[thread overview]
Message-ID: <20060621140125.c27bc99e.akpm@osdl.org> (raw)
In-Reply-To: <20060621204414.GA30766@suse.de>

On Wed, 21 Jun 2006 13:44:15 -0700
Greg KH <gregkh@suse.de> wrote:

> > > Confused.  This patch won't apply.  It will apply with `patch -R', and if
> > > you do that you'll break iomem_reosurce.end by setting it to
> > > 0x00000000ffffffff.
> > > 
> > > I don't think any additional changes are needed here.
> > 
> > Andrew, you don't have to apply this patch. It is supposed to be picked
> > by Greg.
> > 
> > There seems to be some confusion. Just few days back Greg consolidated
> > and re-organized all the 64bit resources patches and posted on LKML for
> > review.
> > 
> > http://marc.theaimsgroup.com/?l=linux-kernel&m=115015916118671&w=2
> > 
> > There were few review comments regarding kconfig options.
> > I reworked the patch and CONFING_RESOURCES_32BIT was changed to
> > CONFIG_RESOURCES_64BIT.
> > 
> > http://marc.theaimsgroup.com/?l=linux-kernel&m=115072559700302&w=2
> > 
> > Now Greg's tree and your tree are not exact replica when it comes to 
> > 64bit resource patches. Hence this patch is supposed to be picked by 
> > Greg to make sure things are not broken in his tree.
> 
> It still breaks things as Andrew pointed out.  .end should not be set to
> -1.

No, -1 is OK.

As it turns out,

	unsigned long long x = ~0UL;

sets `x' to 0xffffffffffffffff which was totally not what I expected.

But -1 works, and the patch I have against your tree is OK.

Could someone please fix Andy Isaacson <adi@hexapodia.org>'s bug, btw?

  parent reply	other threads:[~2006-06-21 21:01 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-21 17:29 [PATCH] 64bit resources start end value fix Vivek Goyal
2006-06-21 20:22 ` Andrew Morton
2006-06-21 20:41   ` Vivek Goyal
2006-06-21 20:44     ` Greg KH
2006-06-21 20:56       ` Vivek Goyal
2006-06-21 21:01       ` Andrew Morton [this message]
2006-06-21 20:58     ` Andrew Morton
2006-06-21 23:15       ` Vivek Goyal
2006-06-21 23:27         ` Andrew Morton
2006-06-22  6:09           ` Greg KH
2006-06-24  2:45 ` Greg KH
2006-06-24 13:15   ` Vivek Goyal
2006-06-24 13:24     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060621140125.c27bc99e.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=greg@kroah.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox