Re: [PATCH] 64bit resources start end value fix

Andrew Morton
2006-06-21T20:59:06Z

On Wed, 21 Jun 2006 16:41:21 -0400
Vivek Goyal <vgoyal@in.ibm.com> wrote:

> > > @@ -32,8 +32,8 @@ EXPORT_SYMBOL(ioport_resource);
> > >
> > > struct resource iomem_resource = {
> > > .name = "PCI mem",
> > > - .start = 0UL,
> > > - .end = ~0UL,
> > > + .start = 0,
> > > + .end = -1,
> > > .flags = IORESOURCE_MEM,
> > > };
> > >
> >
> > Confused. This patch won't apply. It will apply with `patch -R', and if
> > you do that you'll break iomem_reosurce.end by setting it to
> > 0x00000000ffffffff.
> >
> > I don't think any additional changes are needed here.
>
> Andrew, you don't have to apply this patch. It is supposed to be picked
> by Greg.
>
> There seems to be some confusion. Just few days back Greg consolidated
> and re-organized all the 64bit resources patches and posted on LKML for
> review.
>
> http://marc.theaimsgroup.com/?l=linux-kernel&m=115015916118671&w=2
>
> There were few review comments regarding kconfig options.
> I reworked the patch and CONFING_RESOURCES_32BIT was changed to
> CONFIG_RESOURCES_64BIT.
>
> http://marc.theaimsgroup.com/?l=linux-kernel&m=115072559700302&w=2
>
> Now Greg's tree and your tree are not exact replica when it comes to
> 64bit resource patches. Hence this patch is supposed to be picked by
> Greg to make sure things are not broken in his tree.

I'm working against Greg's tree, always...