Re: [PATCH] 64bit resources start end value fix

Andrew Morton
2006-06-21T20:22:36Z

On Wed, 21 Jun 2006 13:29:03 -0400
Vivek Goyal <vgoyal@in.ibm.com> wrote:

> Hi Greg,
>
> While changing 64bit kconfig options to CONFIG_RESOURCES_64BIT, I forgot
> to update the values of start and end fields in ioport_resource and
> iomem_resource.
>
> Following patch applies on top of your reworked 64 bit patches and
> is based on Andrew Morton's patch. Please apply.
>
> http://marc.theaimsgroup.com/?l=linux-mm-commits&m=115087406130723&w=2
>
> Thanks
> Vivek
>
>
>
> o Update start and end fields for 32bit and 64bit resources.
>
> Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
> ---
>
> linux-2.6.17-1M-vivek/kernel/resource.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff -puN kernel/resource.c~64bit-resources-start-end-value-fix kernel/resource.c
> --- linux-2.6.17-1M/kernel/resource.c~64bit-resources-start-end-value-fix 2006-06-21 12:43:43.000000000 -0400
> +++ linux-2.6.17-1M-vivek/kernel/resource.c 2006-06-21 12:44:59.000000000 -0400
> @@ -23,7 +23,7 @@
>
> struct resource ioport_resource = {
> .name = "PCI IO",
> - .start = 0x0000,
> + .start = 0,
> .end = IO_SPACE_LIMIT,
> .flags = IORESOURCE_IO,
> };
> @@ -32,8 +32,8 @@ EXPORT_SYMBOL(ioport_resource);
>
> struct resource iomem_resource = {
> .name = "PCI mem",
> - .start = 0UL,
> - .end = ~0UL,
> + .start = 0,
> + .end = -1,
> .flags = IORESOURCE_MEM,
> };
>

Confused. This patch won't apply. It will apply with `patch -R', and if
you do that you'll break iomem_reosurce.end by setting it to
0x00000000ffffffff.

I don't think any additional changes are needed here.