From: Andrew Morton <akpm@osdl.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: tglx@linutronix.de, linux-kernel@vger.kernel.org, mingo@elte.hu
Subject: Re: [patch 2/3] rtmutex: Propagate priority settings into PI lock chains
Date: Thu, 22 Jun 2006 19:08:25 -0700 [thread overview]
Message-ID: <20060622190825.7da4eeae.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0606220959490.15236@gandalf.stny.rr.com>
On Thu, 22 Jun 2006 10:20:59 -0400 (EDT)
Steven Rostedt <rostedt@goodmis.org> wrote:
> > + if (!waiter || waiter->list_entry.prio == task->prio) {
> > + spin_unlock_irqrestore(&task->pi_lock, flags);
> > + return;
> > + }
> > +
> > + /* gets dropped in rt_mutex_adjust_prio_chain()! */
> > + get_task_struct(task);
> > + spin_unlock_irqrestore(&task->pi_lock, flags);
> > +
> > + rt_mutex_adjust_prio_chain(task, 0, NULL, NULL, task);
>
> The above means that you cant ever call sched_setscheduler from a
> interrupt handler (or softirq). The rt_mutex_adjust_prio_chain since that
> grabs wait_lock which is not for interrupt use.
Running setscheduler() from IRQ context sounds rather perverse.
BUG_ON(in_interrupt()) would reduce the temptation.
next prev parent reply other threads:[~2006-06-23 2:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-22 9:08 [patch 0/3] rtmutex: Propagate priority setting into lock chains Thomas Gleixner
2006-06-22 9:08 ` [patch 1/3] Drop tasklist lock in do_sched_setscheduler Thomas Gleixner
2006-06-23 1:48 ` Andrew Morton
2006-06-23 6:01 ` Thomas Gleixner
2006-06-24 8:07 ` Andrew Morton
2006-06-24 8:25 ` Thomas Gleixner
2006-06-22 9:08 ` [patch 2/3] rtmutex: Propagate priority settings into PI lock chains Thomas Gleixner
2006-06-22 14:20 ` Steven Rostedt
2006-06-22 18:02 ` Esben Nielsen
2006-06-23 6:27 ` Steven Rostedt
2006-06-23 2:08 ` Andrew Morton [this message]
2006-06-23 9:28 ` [PATCH -mm] bug if setscheduler is called from interrupt context Steven Rostedt
2006-06-23 2:06 ` [patch 2/3] rtmutex: Propagate priority settings into PI lock chains Andrew Morton
2006-06-23 16:26 ` Thomas Gleixner
2006-06-22 9:08 ` [patch 3/3] rtmutex: Modify rtmutex-tester to test the setscheduler propagation Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060622190825.7da4eeae.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox