From: Greg KH <greg@kroah.com>
To: Mattia Dongili <malattia@linux.it>, Jiri Slaby <jirislaby@gmail.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
David Brownell <david-b@pacbell.net>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net, linux-pm@osdl.org,
pavel@suse.cz
Subject: [PATCH] get USB suspend to work again on 2.6.17-mm1
Date: Thu, 22 Jun 2006 13:29:52 -0700 [thread overview]
Message-ID: <20060622202952.GA14135@kroah.com> (raw)
Mattai and Jiri, can you try the patch below to see if it fixes the USB
suspend problem you are seeing with 2.6.17-mm1?
David, we really should not be caring about what the children of a USB
device is doing here, as who knows what type of "device" might hang off
of a struct usb_device. This patch is just a band-aid around this area,
until Alan's patches fix up everything "properly" :)
thanks,
greg k-h
-----------------------------
Subject: USB: get USB suspend to work again
Yeah, it's a hack, but it is only temporary until Alan's patches
reworking this area make it in. We really should not care what devices
below us are doing, especially when we do not really know what type of
devices they are. This patch relies on the fact that the endpoint
devices do not have a driver assigned to us.
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
---
drivers/usb/core/usb.c | 2 ++
1 file changed, 2 insertions(+)
--- gregkh-2.6.orig/drivers/usb/core/usb.c
+++ gregkh-2.6/drivers/usb/core/usb.c
@@ -991,6 +991,8 @@ void usb_buffer_unmap_sg (struct usb_dev
static int verify_suspended(struct device *dev, void *unused)
{
+ if (dev->driver == NULL)
+ return 0;
return (dev->power.power_state.event == PM_EVENT_ON) ? -EBUSY : 0;
}
next reply other threads:[~2006-06-22 20:33 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-22 20:29 Greg KH [this message]
2006-06-22 21:27 ` [PATCH] get USB suspend to work again on 2.6.17-mm1 Jiri Slaby
2006-06-22 21:28 ` Mattia Dongili
2006-06-22 21:34 ` Mattia Dongili
2006-06-22 23:24 ` David Brownell
2006-06-22 23:51 ` Greg KH
2006-06-23 2:45 ` Alan Stern
2006-06-23 4:26 ` Greg KH
2006-06-23 14:28 ` Alan Stern
2006-06-23 3:34 ` David Brownell
2006-06-23 4:24 ` Greg KH
2006-06-23 14:51 ` Alan Stern
2006-06-23 15:38 ` [linux-usb-devel] " David Brownell
2006-06-26 23:57 ` Greg KH
2006-06-27 2:04 ` David Brownell
2006-06-27 15:24 ` Alan Stern
2006-06-27 23:28 ` Greg KH
2006-06-27 23:26 ` Greg KH
2006-06-27 9:03 ` Pavel Machek
2006-06-27 17:38 ` David Brownell
2006-06-27 23:20 ` Greg KH
2006-06-25 2:42 ` [linux-pm] " Jim Gettys
2006-06-25 4:32 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060622202952.GA14135@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=david-b@pacbell.net \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@osdl.org \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=malattia@linux.it \
--cc=pavel@suse.cz \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox