From: Kevin Corry <kevcorry@us.ibm.com>
To: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Alasdair G Kergon <agk@redhat.com>
Cc: mbroz@redhat.com, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 01/15] dm: support ioctls on mapped devices
Date: Thu, 22 Jun 2006 22:31:16 -0500 [thread overview]
Message-ID: <200606222231.17465.kevcorry@us.ibm.com> (raw)
In-Reply-To: <20060622095551.b5c6ddce.akpm@osdl.org>
On Thu June 22 2006 11:55 am, Andrew Morton wrote:
> On Thu, 22 Jun 2006 16:17:21 +0100 Alasdair G Kergon <agk@redhat.com> wrote:
> > On Thu, Jun 22, 2006 at 01:29:57AM -0700, Andrew Morton wrote:
> > See also block/scsi_ioctl.c:201 verify_command() [scsi_cmd_ioctl]
> > * file can be NULL from ioctl_by_bdev()...
> >
> > Or should we be working towards eliminating interfaces that use device
> > numbers?
>
> If possible. I guess that would require DM to track the devices with
> file*'s or inode*'s or bdev*'s. Which, I assume, would be non-trivial.
There already is a bdev pointer available. Each "consumed" device get a struct
dm_dev, which has a *bdev field. From the bdev, it looks like we should be
able to get to the gendisk, then the block_device_operations, and then the
ioctl routine (if it exists). Correct?
--
Kevin Corry
kevcorry@us.ibm.com
http://www.ibm.com/linux/
http://evms.sourceforge.net/
next prev parent reply other threads:[~2006-06-23 3:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-21 19:31 [PATCH 01/15] dm: support ioctls on mapped devices Alasdair G Kergon
2006-06-22 3:52 ` Andrew Morton
2006-06-22 8:15 ` Milan Broz
2006-06-22 8:29 ` Andrew Morton
2006-06-22 15:17 ` Alasdair G Kergon
2006-06-22 16:55 ` Andrew Morton
2006-06-23 3:31 ` Kevin Corry [this message]
2006-06-23 3:49 ` Andrew Morton
2006-06-23 10:01 ` Christoph Hellwig
2006-06-23 10:00 ` Christoph Hellwig
[not found] ` <20060623032108.28debec2.akpm@osdl.org>
2006-06-23 13:13 ` Milan Broz
2006-06-22 13:21 ` Alasdair G Kergon
2006-07-05 3:22 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200606222231.17465.kevcorry@us.ibm.com \
--to=kevcorry@us.ibm.com \
--cc=agk@redhat.com \
--cc=akpm@osdl.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox