* broken null test in s390 claw driver
@ 2006-06-23 2:03 Dave Jones
0 siblings, 0 replies; only message in thread
From: Dave Jones @ 2006-06-23 2:03 UTC (permalink / raw)
To: Linux Kernel; +Cc: akpm
Whoops, better hope this never gets passed a null dev in its current state.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6/drivers/s390/net/claw.c~ 2006-06-22 22:01:33.000000000 -0400
+++ linux-2.6/drivers/s390/net/claw.c 2006-06-22 22:02:19.000000000 -0400
@@ -529,7 +529,7 @@ claw_open(struct net_device *dev)
printk(KERN_INFO "%s:%s Enter \n",dev->name,__FUNCTION__);
#endif
CLAW_DBF_TEXT(4,trace,"open");
- if (!dev | (dev->name[0] == 0x00)) {
+ if (!dev || (dev->name[0] == 0x00)) {
CLAW_DBF_TEXT(2,trace,"BadDev");
printk(KERN_WARNING "claw: Bad device at open failing \n");
return -ENODEV;
--
http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-06-23 2:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-23 2:03 broken null test in s390 claw driver Dave Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox