public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Kirill Korotaev <dev@openvz.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Con Kolivas <kernel@kolivas.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] sched: CPU hotplug race vs. set_cpus_allowed()
Date: Fri, 23 Jun 2006 10:18:15 +0200	[thread overview]
Message-ID: <20060623081815.GA919@elte.hu> (raw)
In-Reply-To: <449BA349.6040901@openvz.org>


* Kirill Korotaev <dev@openvz.org> wrote:

> Looks like there is a race between set_cpus_allowed() and 
> move_task_off_dead_cpu(). __migrate_task() doesn't report any err 
> code, so task can be left on its runqueue if its cpus_allowed mask 
> changed so that dest_cpu is not longer a possible target. Also, 
> chaning cpus_allowed mask requires rq->lock being held.
> 
> Signed-Off-By: Kirill Korotaev <dev@openvz.org>

good one!

Acked-by: Ingo Molnar <mingo@elte.hu>

	Ingo

  reply	other threads:[~2006-06-23  8:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-23  8:16 [PATCH] sched: CPU hotplug race vs. set_cpus_allowed() Kirill Korotaev
2006-06-23  8:18 ` Ingo Molnar [this message]
2006-06-23 10:53 ` Con Kolivas
2006-06-24  5:25 ` Andrew Morton
  -- strict thread matches above, loose matches on Subject: below --
2006-06-26  7:58 Kirill Korotaev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060623081815.GA919@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=dev@openvz.org \
    --cc=kernel@kolivas.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox