From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Alasdair G Kergon <agk@redhat.com>,
mbroz@redhat.com, linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH 01/15] dm: support ioctls on mapped devices
Date: Fri, 23 Jun 2006 12:00:18 +0200 [thread overview]
Message-ID: <20060623100018.GA6985@lst.de> (raw)
In-Reply-To: <20060622095551.b5c6ddce.akpm@osdl.org>
On Thu, Jun 22, 2006 at 09:55:51AM -0700, Andrew Morton wrote:
> > - long (*unlocked_ioctl) (struct file *, unsigned, unsigned long);
> > + long (*unlocked_ioctl) (struct inode *, struct file *, unsigned, unsigned long);
> >
> > so it can be used for block devices?
>
> Perhaps it should (have). It's a bit nasty, but we do have at least two
> internal callers who don't have a file*.
>
> The alternative would be to cook up a fake file* like blkdev_get() does,
> but we don't want to propagate that practice.
Faking up the file struct is the only viable short-term option. It
should be done in ioctl_by_bdev which every kernel blockdevice ioctl
user should use. Long-term we should not pass a struct file but
a struct block_device *, but braindamage in floppy.c prevents that.
next prev parent reply other threads:[~2006-06-23 10:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-21 19:31 [PATCH 01/15] dm: support ioctls on mapped devices Alasdair G Kergon
2006-06-22 3:52 ` Andrew Morton
2006-06-22 8:15 ` Milan Broz
2006-06-22 8:29 ` Andrew Morton
2006-06-22 15:17 ` Alasdair G Kergon
2006-06-22 16:55 ` Andrew Morton
2006-06-23 3:31 ` Kevin Corry
2006-06-23 3:49 ` Andrew Morton
2006-06-23 10:01 ` Christoph Hellwig
2006-06-23 10:00 ` Christoph Hellwig [this message]
[not found] ` <20060623032108.28debec2.akpm@osdl.org>
2006-06-23 13:13 ` Milan Broz
2006-06-22 13:21 ` Alasdair G Kergon
2006-07-05 3:22 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060623100018.GA6985@lst.de \
--to=hch@lst.de \
--cc=agk@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroz@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox