* [PATCH] Fix cpufreq_{conservative,ondemand} compilation
@ 2006-06-23 10:12 Jean Delvare
0 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2006-06-23 10:12 UTC (permalink / raw)
To: Venkatesh Pallipadi; +Cc: LKML
Fix cpufreq_conservative and cpufreq_ondemand, which were using
{lock,unlock}_cpu_hotplug without including linux/cpu.h which defines
them.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
drivers/cpufreq/cpufreq_conservative.c | 1 +
drivers/cpufreq/cpufreq_ondemand.c | 1 +
2 files changed, 2 insertions(+)
--- linux-2.6.17-git.orig/drivers/cpufreq/cpufreq_conservative.c 2006-06-23 10:24:17.000000000 +0200
+++ linux-2.6.17-git/drivers/cpufreq/cpufreq_conservative.c 2006-06-23 12:07:42.000000000 +0200
@@ -17,6 +17,7 @@
#include <linux/init.h>
#include <linux/interrupt.h>
#include <linux/ctype.h>
+#include <linux/cpu.h>
#include <linux/cpufreq.h>
#include <linux/sysctl.h>
#include <linux/types.h>
--- linux-2.6.17-git.orig/drivers/cpufreq/cpufreq_ondemand.c 2006-06-23 10:24:17.000000000 +0200
+++ linux-2.6.17-git/drivers/cpufreq/cpufreq_ondemand.c 2006-06-23 12:07:34.000000000 +0200
@@ -16,6 +16,7 @@
#include <linux/init.h>
#include <linux/interrupt.h>
#include <linux/ctype.h>
+#include <linux/cpu.h>
#include <linux/cpufreq.h>
#include <linux/sysctl.h>
#include <linux/types.h>
--
Jean Delvare
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] Fix cpufreq_{conservative,ondemand} compilation
@ 2006-06-23 17:20 Pallipadi, Venkatesh
2006-06-23 19:50 ` Jean Delvare
2006-06-23 20:24 ` Krzysztof Halasa
0 siblings, 2 replies; 4+ messages in thread
From: Pallipadi, Venkatesh @ 2006-06-23 17:20 UTC (permalink / raw)
To: Jean Delvare; +Cc: LKML
Thanks for the patch. Yes, I had missed this warning as some other patch
in my local tree was adding cpu.h to cpufreq_ondemand.c
Thanks,
Venki
>-----Original Message-----
>From: Jean Delvare [mailto:khali@linux-fr.org]
>Sent: Friday, June 23, 2006 3:13 AM
>To: Pallipadi, Venkatesh
>Cc: LKML
>Subject: [PATCH] Fix cpufreq_{conservative,ondemand} compilation
>
>Fix cpufreq_conservative and cpufreq_ondemand, which were using
>{lock,unlock}_cpu_hotplug without including linux/cpu.h which defines
>them.
>
>Signed-off-by: Jean Delvare <khali@linux-fr.org>
>---
> drivers/cpufreq/cpufreq_conservative.c | 1 +
> drivers/cpufreq/cpufreq_ondemand.c | 1 +
> 2 files changed, 2 insertions(+)
>
>---
>linux-2.6.17-git.orig/drivers/cpufreq/cpufreq_conservative.c
>2006-06-23 10:24:17.000000000 +0200
>+++ linux-2.6.17-git/drivers/cpufreq/cpufreq_conservative.c
>2006-06-23 12:07:42.000000000 +0200
>@@ -17,6 +17,7 @@
> #include <linux/init.h>
> #include <linux/interrupt.h>
> #include <linux/ctype.h>
>+#include <linux/cpu.h>
> #include <linux/cpufreq.h>
> #include <linux/sysctl.h>
> #include <linux/types.h>
>--- linux-2.6.17-git.orig/drivers/cpufreq/cpufreq_ondemand.c
>2006-06-23 10:24:17.000000000 +0200
>+++ linux-2.6.17-git/drivers/cpufreq/cpufreq_ondemand.c
>2006-06-23 12:07:34.000000000 +0200
>@@ -16,6 +16,7 @@
> #include <linux/init.h>
> #include <linux/interrupt.h>
> #include <linux/ctype.h>
>+#include <linux/cpu.h>
> #include <linux/cpufreq.h>
> #include <linux/sysctl.h>
> #include <linux/types.h>
>
>
>--
>Jean Delvare
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Fix cpufreq_{conservative,ondemand} compilation
2006-06-23 17:20 Pallipadi, Venkatesh
@ 2006-06-23 19:50 ` Jean Delvare
2006-06-23 20:24 ` Krzysztof Halasa
1 sibling, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2006-06-23 19:50 UTC (permalink / raw)
To: Pallipadi, Venkatesh; +Cc: LKML
Venki,
> Thanks for the patch. Yes, I had missed this warning as some other patch
> in my local tree was adding cpu.h to cpufreq_ondemand.c
Oh well, a similar patch was merged by Andrew Morton already.
--
Jean Delvare
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Fix cpufreq_{conservative,ondemand} compilation
2006-06-23 17:20 Pallipadi, Venkatesh
2006-06-23 19:50 ` Jean Delvare
@ 2006-06-23 20:24 ` Krzysztof Halasa
1 sibling, 0 replies; 4+ messages in thread
From: Krzysztof Halasa @ 2006-06-23 20:24 UTC (permalink / raw)
To: Pallipadi, Venkatesh; +Cc: Jean Delvare, LKML
"Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com> writes:
> Thanks for the patch. Yes, I had missed this warning as some other patch
> in my local tree was adding cpu.h to cpufreq_ondemand.c
BTW: why can't we have "ondemand" (and others) by default (only
"performance" or "userspace")?
--
Krzysztof Halasa
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2006-06-23 20:24 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-23 10:12 [PATCH] Fix cpufreq_{conservative,ondemand} compilation Jean Delvare
-- strict thread matches above, loose matches on Subject: below --
2006-06-23 17:20 Pallipadi, Venkatesh
2006-06-23 19:50 ` Jean Delvare
2006-06-23 20:24 ` Krzysztof Halasa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox