From: Vitaly Wool <vitalywool@gmail.com>
To: Mark Underwood <basicmark@yahoo.com>
Cc: greg@kroah.com, i2c@lm-sensors.org,
linux-arm-kernel@lists.arm.linux.org.uk,
linux-kernel@vger.kernel.org
Subject: Re: [i2c] [PATCH] I2C bus driver for Philips ARM boards
Date: Fri, 23 Jun 2006 13:38:55 +0400 [thread overview]
Message-ID: <20060623133855.59b08f33.vitalywool@gmail.com> (raw)
In-Reply-To: <20060622222600.49601.qmail@web36915.mail.mud.yahoo.com>
On Thu, 22 Jun 2006 23:26:00 +0100 (BST)
Mark Underwood <basicmark@yahoo.com> wrote:
> Would it not make sense to call this driver ip3204 or ph_ip3204 or some such seeing as you
> correctly point out that this is a common Philips IP block and is used in other, non pnx, chips?
No I don't think it would -- this is an internal Philips IP block number AFAIK and was given there only for reference.
Funny is that people from Philips Semi asked me about a year ago not to use internal IP block numbers in the code. I know you're also from Philips... Well, what does that prove? It proves that everything can't be in alignment in such a big company. ;-)
> I'm also not sure why the register map is in the arch-pnx4008 directory as this will require every
> chip that has this IP block to have a copy of the file.
IIRC, PNX5220 has a slightly different register map. Of course the main registers are the same but putting first N regs into common header and putting others into arch header would have made even less sense.
Vitaly
next prev parent reply other threads:[~2006-06-23 9:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-22 11:31 [PATCH] I2C bus driver for Philips ARM boards Vitaly Wool
2006-06-22 11:45 ` Ben Dooks
2006-06-22 12:08 ` Vitaly Wool
2006-06-22 18:39 ` [i2c] " Greg KH
[not found] ` <acd2a5930606221317w6432aefcsf4569fca3b59ebcd@mail.gmail.com>
2006-06-22 20:35 ` Greg KH
2006-06-22 22:26 ` Mark Underwood
2006-06-23 9:38 ` Vitaly Wool [this message]
2006-06-23 12:16 ` Mark Underwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060623133855.59b08f33.vitalywool@gmail.com \
--to=vitalywool@gmail.com \
--cc=basicmark@yahoo.com \
--cc=greg@kroah.com \
--cc=i2c@lm-sensors.org \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox