* [patch 4/4] lock validator: fix qeth compile warning
@ 2006-06-23 13:28 Heiko Carstens
2006-06-23 13:40 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Heiko Carstens @ 2006-06-23 13:28 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Ingo Molnar, Arjan van de Ven, Frank Pavlic
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Add #ifdef CONFIG_LOCKDEP to avoid compile warning.
Cc: Frank Pavlic <fpavlic@de.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
drivers/s390/net/qeth_main.c | 2 ++
1 file changed, 2 insertions(+)
Index: linux-2.6.17-mm1/drivers/s390/net/qeth_main.c
===================================================================
--- linux-2.6.17-mm1.orig/drivers/s390/net/qeth_main.c
+++ linux-2.6.17-mm1/drivers/s390/net/qeth_main.c
@@ -85,7 +85,9 @@ static debug_info_t *qeth_dbf_qerr = NUL
DEFINE_PER_CPU(char[256], qeth_dbf_txt_buf);
+#ifdef CONFIG_LOCKDEP
static struct lockdep_type_key qdio_out_skb_queue_key;
+#endif
/**
* some more definitions and declarations
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 4/4] lock validator: fix qeth compile warning
2006-06-23 13:28 [patch 4/4] lock validator: fix qeth compile warning Heiko Carstens
@ 2006-06-23 13:40 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2006-06-23 13:40 UTC (permalink / raw)
To: Heiko Carstens
Cc: Andrew Morton, linux-kernel, Arjan van de Ven, Frank Pavlic
* Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> +#ifdef CONFIG_LOCKDEP
> static struct lockdep_type_key qdio_out_skb_queue_key;
> +#endif
ok, that's fine for now. I'm cleaning this up via introducing
per-lock-variant keys. But maybe the best would be to offer the lock
validator in a binary way only - either for all lock variants at once,
or for none at all?
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-06-23 14:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-23 13:28 [patch 4/4] lock validator: fix qeth compile warning Heiko Carstens
2006-06-23 13:40 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox