From: Greg KH <gregkh@suse.de>
To: Linas Vepstas <linas@austin.ibm.com>
Cc: Greg KH <greg@kroah.com>,
linux-pci@atrey.karlin.mff.cuni.cz,
Eric Sesterhenn <snakebyte@gmx.de>,
linux-kernel@vger.kernel.org
Subject: Re: Fault tolerance/bad patch, [was Re: [PATCH 29/30] [PATCH] PCI Hotplug: fake NULL pointer dereferences in IBM Hot Plug Controller Driver]
Date: Fri, 23 Jun 2006 11:33:16 -0700 [thread overview]
Message-ID: <20060623183316.GA4529@suse.de> (raw)
In-Reply-To: <20060623150442.GK8866@austin.ibm.com>
On Fri, Jun 23, 2006 at 10:04:43AM -0500, Linas Vepstas wrote:
> Hi,
>
> On Mon, Jun 19, 2006 at 02:43:35PM -0700, Greg KH wrote:
> > From: Eric Sesterhenn <snakebyte@gmx.de>
> >
> > Remove checks for value, since the hotplug core always provides
> > a valid value.
> >
> > - if (hotplug_slot && value) {
> > + if (hotplug_slot) {
>
> This may be the wrong place to bring up a philosphical issue,
You are right, it is the wrong place for it, please take stuff like this
elsewhere.
value can not be a null value here, it's an impossiblity as that is how
this interface works.
thanks,
greg k-h
prev parent reply other threads:[~2006-06-23 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1150753481625-git-send-email-greg@kroah.com>
[not found] ` <115075348565-git-send-email-greg@kroah.com>
[not found] ` <11507534883521-git-send-email-greg@kroah.com>
[not found] ` <11507534914002-git-send-email-greg@kroah.com>
[not found] ` <11507534953044-git-send-email-greg@kroah.com>
[not found] ` <11507534983982-git-send-email-greg@kroah.com>
[not found] ` <11507535021937-git-send-email-greg@kroah.com>
[not found] ` <11507535054091-git-send-email-greg@kroah.com>
[not found] ` <11507535082418-git-send-email-greg@kroah.com>
[not found] ` <11507535123764-git-send-email-greg@kroah.com>
2006-06-23 15:04 ` Fault tolerance/bad patch, [was Re: [PATCH 29/30] [PATCH] PCI Hotplug: fake NULL pointer dereferences in IBM Hot Plug Controller Driver] Linas Vepstas
2006-06-23 15:28 ` Alan Cox
2006-06-23 15:52 ` Eric Sesterhenn / Snakebyte
2006-06-23 18:33 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060623183316.GA4529@suse.de \
--to=gregkh@suse.de \
--cc=greg@kroah.com \
--cc=linas@austin.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox