From: Vivek Goyal <vgoyal@in.ibm.com>
To: Amul Shah <amul.shah@unisys.com>
Cc: Takashi Iwai <tiwai@suse.de>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, fastboot@osdl.org,
Eric Biederman <ebiederm@xmission.com>,
Randy Dunlap <rdunlap@xenotime.net>
Subject: Re: [Fastboot] [PATCH] Fix kdump Crash Kernel boot memory reservation for NUMA machines
Date: Fri, 23 Jun 2006 15:10:02 -0400 [thread overview]
Message-ID: <20060623191002.GD7551@in.ibm.com> (raw)
In-Reply-To: <1151089038.29121.32.camel@b4.na.uis.unisys.com>
On Fri, Jun 23, 2006 at 02:57:17PM -0400, Amul Shah wrote:
> This patch will fix a boot memory reservation bug that trashes memory on
> the ES7000 when loading the kdump crash kernel.
>
> The code in arch/x86_64/kernel/setup.c to reserve boot memory for the
> crash kernel uses the non-numa aware "reserve_bootmem" function instead
> of the NUMA aware "reserve_bootmem_generic". I checked to make sure
> that no other function was using "reserve_bootmem" and found none,
> except the ones that had NUMA ifdef'ed out.
>
> I have tested this patch only on an ES7000 with NUMA on and off (numa=off)
> in a single (non-NUMA) and multi-cell (NUMA) configurations.
>
> Signed-off-by: Amul Shah <amul.shah@unisys.com>
>
>
> ---
> --- linux-2.6.16.18-1.8/arch/x86_64/kernel/setup.c 2006-06-06 12:07:42.000000000 -0400
> +++ linux-2.6.16.18-1.8-az/arch/x86_64/kernel/setup.c 2006-06-21 17:06:04.000000000 -0400
> @@ -715,7 +715,7 @@ void __init setup_arch(char **cmdline_p)
> #endif
> #ifdef CONFIG_KEXEC
> if (crashk_res.start != crashk_res.end) {
> - reserve_bootmem(crashk_res.start,
> + reserve_bootmem_generic(crashk_res.start,
> crashk_res.end - crashk_res.start + 1);
> }
Looks good to me. I know of a 64w NUMA machine test results and kdump
was successful. Not sure why did not we see the problem there. But
anyway this is logical.
Thanks
Vivek
prev parent reply other threads:[~2006-06-23 19:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-23 18:57 [PATCH] Fix kdump Crash Kernel boot memory reservation for NUMA machines Amul Shah
2006-06-23 19:10 ` Vivek Goyal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060623191002.GD7551@in.ibm.com \
--to=vgoyal@in.ibm.com \
--cc=akpm@osdl.org \
--cc=amul.shah@unisys.com \
--cc=ebiederm@xmission.com \
--cc=fastboot@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox