From: mark gross <mgross@linux.intel.com>
To: linux-kernel@vger.kernel.org
Cc: mbellon@mvista.com, mark.gross@intel.com
Subject: [PATCH] type-oh bug in tlclk.c
Date: Fri, 23 Jun 2006 15:13:07 -0700 [thread overview]
Message-ID: <20060623221307.GA5205@linux.intel.com> (raw)
Mark Bellon found a bug in my tlclk driver. Thanks!
I botch the register mask for store_received_ref_clk3a.
See http://download.intel.com/design/network/manuals/30412001.pdf
tables 124 and 136 for details.
Please apply.
thanks,
--mgross
Signed-off-by : Mark Gross <mark.gross@intel.com>
diff -urN -X ../linux-2.6.17.1/Documentation/dontdiff ../linux-2.6.17.1/drivers/char/tlclk.c tlclk/linux-2.6.17.1/drivers/char/tlclk.c
--- ../linux-2.6.17.1/drivers/char/tlclk.c 2006-06-20 02:31:55.000000000 -0700
+++ tlclk/linux-2.6.17.1/drivers/char/tlclk.c 2006-06-23 14:12:21.000000000 -0700
@@ -343,7 +343,7 @@
val = (unsigned char)tmp;
spin_lock_irqsave(&event_lock, flags);
- SET_PORT_BITS(TLCLK_REG1, 0xef, val << 1);
+ SET_PORT_BITS(TLCLK_REG1, 0xdf, val << 1);
spin_unlock_irqrestore(&event_lock, flags);
return strnlen(buf, count);
reply other threads:[~2006-06-23 22:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060623221307.GA5205@linux.intel.com \
--to=mgross@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.gross@intel.com \
--cc=mbellon@mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox