public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Dave Jones <davej@redhat.com>
Cc: torvalds@osdl.org, discuss@x86-64.org, akpm@osdl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [20/82] i386: Panic the system when a NUMA kernel doesn't run on IBM NUMA
Date: Sat, 24 Jun 2006 02:42:31 +0200	[thread overview]
Message-ID: <200606240242.31906.ak@suse.de> (raw)
In-Reply-To: <20060624003856.GE19461@redhat.com>

On Saturday 24 June 2006 02:38, Dave Jones wrote:
> On Sat, Jun 24, 2006 at 02:19:28AM +0200, Andi Kleen wrote:
> 
> 
>  > +	extern int use_cyclone;
>  > +	if (use_cyclone == 0) {
>  > +		/* Make sure user sees something */
>  > +		static const char s[] __initdata = "Not an IBM x440/NUMAQ. Don't use i386 CONFIG_NUMA anywhere else.";
>  > +		early_printk(s);
>  > +		panic(s);
>  > +	}
> 
> non-IBM Machines do still boot with that enabled though don't they?


No they don't - as they likely didn't do before. e.g. Opterons generally
break and that brings the point across clearer.

The rationale is that CONFIG_NUMA is very rarely used on i386 (even on summit)
and always does bitrot quickly. It also doesn't work at all on a wide
range of machines.

I'm sure someone will bring up now an example where their non Summit 
machine booted with CONFIG_NUMA, but they were just extremly lucky
and unlikely to be for very long.

-Andi

  reply	other threads:[~2006-06-24  0:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-24  0:19 [PATCH] [20/82] i386: Panic the system when a NUMA kernel doesn't run on IBM NUMA Andi Kleen
2006-06-24  0:38 ` Dave Jones
2006-06-24  0:42   ` Andi Kleen [this message]
2006-06-24  1:03     ` Keith Mannthey
2006-06-24  1:15       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200606240242.31906.ak@suse.de \
    --to=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=davej@redhat.com \
    --cc=discuss@x86-64.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox