* [PATCH] fix "Trying to free nonexistent resource" format string
@ 2006-06-21 17:57 Andy Isaacson
2006-06-24 2:44 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Andy Isaacson @ 2006-06-21 17:57 UTC (permalink / raw)
To: akpm; +Cc: Greg KH, linux-kernel
In 2.6.17-mm1, the patch
gregkh-pci-64bit-resource-fix-up-printks-for-resources-in-arch-and-core-code.patch
has some formatting bugs.
* converts %08x into %16llx, which results in space-padding rather than
zero-padding.
* some casts are insufficiently touchy-feely with their castees.
This patch fixes them.
Signed-off-by: Andy Isaacson <adi@hexapodia.org>
Index: q-2.6.17-mm1/kernel/resource.c
===================================================================
--- q-2.6.17-mm1.orig/kernel/resource.c 2006-06-21 10:55:05.000000000 -0700
+++ q-2.6.17-mm1/kernel/resource.c 2006-06-21 10:55:49.000000000 -0700
@@ -558,8 +558,8 @@
write_unlock(&resource_lock);
printk(KERN_WARNING "Trying to free nonexistent resource "
- "<%16llx-%16llx>\n", (unsigned long long)start,
- (unsigned long long) end);
+ "<%016llx-%016llx>\n", (unsigned long long)start,
+ (unsigned long long)end);
}
EXPORT_SYMBOL(__release_region);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fix "Trying to free nonexistent resource" format string
2006-06-21 17:57 [PATCH] fix "Trying to free nonexistent resource" format string Andy Isaacson
@ 2006-06-24 2:44 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2006-06-24 2:44 UTC (permalink / raw)
To: Andy Isaacson; +Cc: akpm, linux-kernel
On Wed, Jun 21, 2006 at 10:57:00AM -0700, Andy Isaacson wrote:
> In 2.6.17-mm1, the patch
> gregkh-pci-64bit-resource-fix-up-printks-for-resources-in-arch-and-core-code.patch
> has some formatting bugs.
> * converts %08x into %16llx, which results in space-padding rather than
> zero-padding.
> * some casts are insufficiently touchy-feely with their castees.
>
> This patch fixes them.
>
> Signed-off-by: Andy Isaacson <adi@hexapodia.org>
Thanks, I've merged this in with the original patch and added your
Signed-off-by to it.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-06-24 2:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-21 17:57 [PATCH] fix "Trying to free nonexistent resource" format string Andy Isaacson
2006-06-24 2:44 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox