From: Wu Fengguang <wfg@mail.ustc.edu.cn>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Wu Fengguang <wfg@mail.ustc.edu.cn>
Subject: [PATCH 6/6] readahead: remove the size limit of max_sectors_kb on read_ahead_kb
Date: Sun, 25 Jun 2006 21:07:10 +0800 [thread overview]
Message-ID: <351240953.20240@ustc.edu.cn> (raw)
Message-ID: <20060625130923.154258797@localhost.localdomain> (raw)
In-Reply-To: 20060625130704.464870100@localhost.localdomain
[-- Attachment #1: readahead-size-limited-by-max-sectors-fix.patch --]
[-- Type: text/plain, Size: 1074 bytes --]
Remove the corelation between max_sectors_kb and read_ahead_kb.
It's unnecessary to reduce readahead size when setting max_sectors_kb.
Signed-off-by: Wu Fengguang <wfg@mail.ustc.edu.cn>
---
--- linux-2.6.17-mm2.orig/block/ll_rw_blk.c
+++ linux-2.6.17-mm2/block/ll_rw_blk.c
@@ -3851,25 +3851,11 @@ queue_max_sectors_store(struct request_q
max_hw_sectors_kb = q->max_hw_sectors >> 1,
page_kb = 1 << (PAGE_CACHE_SHIFT - 10);
ssize_t ret = queue_var_store(&max_sectors_kb, page, count);
- int ra_kb;
if (max_sectors_kb > max_hw_sectors_kb || max_sectors_kb < page_kb)
return -EINVAL;
- /*
- * Take the queue lock to update the readahead and max_sectors
- * values synchronously:
- */
- spin_lock_irq(q->queue_lock);
- /*
- * Trim readahead window as well, if necessary:
- */
- ra_kb = q->backing_dev_info.ra_pages << (PAGE_CACHE_SHIFT - 10);
- if (ra_kb > max_sectors_kb)
- q->backing_dev_info.ra_pages =
- max_sectors_kb >> (PAGE_CACHE_SHIFT - 10);
q->max_sectors = max_sectors_kb << 1;
- spin_unlock_irq(q->queue_lock);
return ret;
}
--
next prev parent reply other threads:[~2006-06-25 13:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060625130704.464870100@localhost.localdomain>
2006-06-25 13:07 ` [PATCH 0/6] Adaptive readahead updates 3 Wu Fengguang
[not found] ` <20060625130921.549904049@localhost.localdomain>
2006-06-25 13:07 ` [PATCH 1/6] readahead: context based method - slow start Wu Fengguang
[not found] ` <20060626023529.GB6120@mail.ustc.edu.cn>
2006-06-26 2:35 ` [updated PATCH " Wu Fengguang
[not found] ` <20060625130921.987235199@localhost.localdomain>
2006-06-25 13:07 ` [PATCH 2/6] readahead: backward prefetching method fix Wu Fengguang
[not found] ` <20060625130922.216691316@localhost.localdomain>
2006-06-25 13:07 ` [PATCH 3/6] readahead: kconfig option READAHEAD_ALLOW_OVERHEADS Wu Fengguang
[not found] ` <20060625130922.816467605@localhost.localdomain>
2006-06-25 13:07 ` [PATCH 5/6] readahead: kconfig option READAHEAD_HIT_FEEDBACK Wu Fengguang
[not found] ` <20060625130923.154258797@localhost.localdomain>
2006-06-25 13:07 ` Wu Fengguang [this message]
[not found] ` <20060626015256.GA6120@mail.ustc.edu.cn>
2006-06-26 1:52 ` [PATCH 0/6] Adaptive readahead updates 3 Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=351240953.20240@ustc.edu.cn \
--to=wfg@mail.ustc.edu.cn \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox