public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: mitr@volny.cz
Cc: dtor_core@ameritech.net, linux-input@atrey.karlin.mff.cuni.cz,
	linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/input/misc/wistron_btns.c: section fixes
Date: Mon, 26 Jun 2006 12:35:09 +0200	[thread overview]
Message-ID: <20060626103509.GQ23314@stusta.de> (raw)

This patch contains the following fixes:
- it doesn't make sense to mark a variable on the stack as __initdata
- struct dmi_ids is using the __init dmi_matched()
  since the only user of struct dmi_ids is the __init select_keymap(),
  the solution is to make struct dmi_ids __initdata

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/input/misc/wistron_btns.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.17-mm2-full/drivers/input/misc/wistron_btns.c.old	2006-06-26 02:03:20.000000000 +0200
+++ linux-2.6.17-mm2-full/drivers/input/misc/wistron_btns.c	2006-06-26 02:07:58.000000000 +0200
@@ -94,7 +94,7 @@
 
 static ssize_t __init locate_wistron_bios(void __iomem *base)
 {
-	static const unsigned char __initdata signature[] =
+	static const unsigned char signature[] =
 		{ 0x42, 0x21, 0x55, 0x30 };
 	ssize_t offset;
 
@@ -333,7 +333,7 @@
  * a list of buttons and their key codes (reported when loading this module
  * with force=1) and the output of dmidecode to $MODULE_AUTHOR.
  */
-static struct dmi_system_id dmi_ids[] = {
+static struct dmi_system_id __initdata dmi_ids[] = {
 	{
 		.callback = dmi_matched,
 		.ident = "Fujitsu-Siemens Amilo Pro V2000",


             reply	other threads:[~2006-06-26 10:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-26 10:35 Adrian Bunk [this message]
2006-06-26 11:50 ` [2.6 patch] drivers/input/misc/wistron_btns.c: section fixes Dmitry Torokhov
2006-06-26 14:10   ` Dmitry Torokhov
2006-06-29 16:49   ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060626103509.GQ23314@stusta.de \
    --to=bunk@stusta.de \
    --cc=dtor_core@ameritech.net \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mitr@volny.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox