From: Rajesh Shah <rajesh.shah@intel.com>
To: Greg KH <gregkh@suse.de>
Cc: Andi Kleen <ak@suse.de>,
rajesh.shah@intel.com, akpm@osdl.org, brice@myri.com,
76306.1226@compuserve.com, arjan@linux.intel.com,
linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org
Subject: Re: [patch 2/2] x86_64 PCI: improve extended config space verification
Date: Mon, 26 Jun 2006 17:57:20 -0700 [thread overview]
Message-ID: <20060626175720.A31701@unix-os.sc.intel.com> (raw)
In-Reply-To: <20060623224318.GB31139@suse.de>; from gregkh@suse.de on Fri, Jun 23, 2006 at 03:43:18PM -0700
On Fri, Jun 23, 2006 at 03:43:18PM -0700, Greg KH wrote:
> On Fri, Jun 23, 2006 at 10:30:36PM +0200, Andi Kleen wrote:
> > On Friday 23 June 2006 22:09, rajesh.shah@intel.com wrote:
> > > Extend the verification for PCI-X/PCI-Express extended config
> > > space pointer. This patch checks whether the MCFG address range
> > > is listed as a motherboard resource, per the PCI firmware spec.
> > > The old check only looked in int 15 e820 memory map, causing
> > > several systems to fail the verification and lose extended
> > > config space.
> >
> > By adding so much code to it you volunteered to factor the
> > sanity check into a common i386/x86-64 file first.
>
> I agree :)
>
> Also, have you looked at the current -git tree? It also modified some
> stuff in this area? Look at commit
> ead2bfeb7f739d2ad6e09dc1343f0da51feb7f51 for details.
>
OK, I just reposted after moving the code to a common file. I did
check that it compiled against the current -git tree, though the
testing was done with -mm2. This did give me back my extended
config space, but it would also be nice if it made a difference
to the other folks who had reported this problem (CC'd).
thanks,
Rajesh
next prev parent reply other threads:[~2006-06-27 1:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-23 20:09 [patch 0/2] PCI: improve extended config space verification rajesh.shah
2006-06-23 20:09 ` [patch 1/2] i386 " rajesh.shah
2006-06-23 20:09 ` [patch 2/2] x86_64 " rajesh.shah
2006-06-23 20:30 ` Andi Kleen
2006-06-23 22:43 ` Greg KH
2006-06-27 0:57 ` Rajesh Shah [this message]
2006-06-23 20:18 ` [patch 0/2] " Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2006-06-27 0:45 [patch 0/2] PCI: improve extended config space verification - take #2 rajesh.shah
2006-06-27 0:45 ` [patch 2/2] x86_64 PCI: improve extended config space verification rajesh.shah
2006-06-27 4:28 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060626175720.A31701@unix-os.sc.intel.com \
--to=rajesh.shah@intel.com \
--cc=76306.1226@compuserve.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=arjan@linux.intel.com \
--cc=brice@myri.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox