public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Linus Torvalds <torvalds@osdl.org>
Subject: [patch] irq: fix arch/i386/kernel/irq.c gcc warning
Date: Tue, 27 Jun 2006 11:28:01 +0200	[thread overview]
Message-ID: <20060627092801.GA4196@elte.hu> (raw)
In-Reply-To: <20060627015211.ce480da6.akpm@osdl.org>


* Andrew Morton <akpm@osdl.org> wrote:

> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm3/

> Changes since 2.6.17-mm2:
> 
>  origin.patch

upstream grew a new compiler warning in i386 irq.c. Patch below fixes 
it. No change in resulting irq.o code.

	Ingo

-------------
Subject: irq: fix arch/i386/kernel/irq.c gcc warning
From: Ingo Molnar <mingo@elte.hu>

add parantheses. (code was fine because & has a higher precedence than |,
but it's a dangerous construct in general and gcc also emits a warning)

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/i386/kernel/irq.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux/arch/i386/kernel/irq.c
===================================================================
--- linux.orig/arch/i386/kernel/irq.c
+++ linux/arch/i386/kernel/irq.c
@@ -104,8 +104,8 @@ fastcall unsigned int do_IRQ(struct pt_r
 		 * softirq checks work in the hardirq context.
 		 */
 		irqctx->tinfo.preempt_count =
-			irqctx->tinfo.preempt_count & ~SOFTIRQ_MASK |
-			curctx->tinfo.preempt_count & SOFTIRQ_MASK;
+			(irqctx->tinfo.preempt_count & ~SOFTIRQ_MASK) |
+			(curctx->tinfo.preempt_count & SOFTIRQ_MASK);
 
 		asm volatile(
 			"       xchgl   %%ebx,%%esp      \n"

  parent reply	other threads:[~2006-06-27  9:32 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-27  8:52 2.6.17-mm3 Andrew Morton
2006-06-27  9:14 ` 2.6.17-mm3: no help text for READAHEAD_ALLOW_OVERHEADS Adrian Bunk
     [not found]   ` <20060627134337.GA6117@mail.ustc.edu.cn>
2006-06-27 13:43     ` Wu Fengguang
2006-06-27 14:40     ` Adrian Bunk
     [not found]       ` <20060627155227.GA6014@mail.ustc.edu.cn>
2006-06-27 15:52         ` Wu Fengguang
2006-06-27 17:46       ` Randy.Dunlap
2006-06-27 17:55         ` Adrian Bunk
2006-06-27  9:28 ` Ingo Molnar [this message]
2006-06-27 11:06   ` [patch] irq: fix arch/i386/kernel/irq.c gcc warning Björn Steinbrink
2006-06-27 11:14 ` x86_64-mm-ieee1394-early.patch (was Re: 2.6.17-mm3) Stefan Richter
2006-06-27 11:17 ` 2.6.17-mm3 Reuben Farrelly
2006-06-27 11:48 ` 2.6.17-mm3 Reuben Farrelly
2006-06-27 14:12 ` 2.6.17-mm3 Michal Piotrowski
2006-06-27 21:38 ` 2.6.17-mm3 Steve Fox
2006-06-27 23:12   ` 2.6.17-mm3 Martin Bligh
2006-06-27 22:40 ` 2.6.17-mm3: arm: *_irq_wake compile error Adrian Bunk
2006-06-28  7:09   ` Thomas Gleixner
2006-06-28  7:12     ` Andrew Morton
2006-06-28  7:20       ` Thomas Gleixner
2006-06-28  8:13         ` Ingo Molnar
2006-06-28  8:30           ` [patch] genirq: rename desc->handler to desc->chip, sparc64 fix Ingo Molnar
2006-06-28  8:39             ` David Miller
2006-06-28  8:48               ` Andrew Morton
2006-06-28  8:47                 ` Ingo Molnar
2006-06-28  9:24                 ` David Miller
2006-06-29  4:58                 ` Paul Mackerras
2006-06-29  6:42                   ` Ingo Molnar
2006-06-28 12:03 ` 2.6.17-mm3 - mutex warning in usbhid, battery problem, and slab corruption Rafael J. Wysocki
2006-06-28 12:09   ` Andrew Morton
2006-06-28 14:14 ` 2.6.17-mm3 Cedric Le Goater
2006-06-28 16:54 ` [-mm patch] make drivers/scsi/aic7xxx/aic79xx_core.:ahd_set_tags() static Adrian Bunk
2006-06-28 16:54 ` [-mm patch] kernel/rcutorture.c: make code static Adrian Bunk
2006-06-28 17:13   ` Paul E. McKenney
2006-06-28 17:17     ` Adrian Bunk
2006-06-28 17:49       ` Paul E. McKenney
2006-06-28 20:18   ` Paul E. McKenney
2006-06-28 16:55 ` [-mm patch] kernel/lockdep.c: possible cleanups Adrian Bunk
2006-06-29 13:49   ` Ingo Molnar
2006-06-28 16:55 ` [-mm patch] fs/ecryptfs/: " Adrian Bunk
2006-06-28 18:40   ` Michael Halcrow

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060627092801.GA4196@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox