From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030186AbWF0OkV (ORCPT ); Tue, 27 Jun 2006 10:40:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030188AbWF0OkV (ORCPT ); Tue, 27 Jun 2006 10:40:21 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:36102 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S1030186AbWF0OkU (ORCPT ); Tue, 27 Jun 2006 10:40:20 -0400 Date: Tue, 27 Jun 2006 16:40:19 +0200 From: Adrian Bunk To: Wu Fengguang , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: 2.6.17-mm3: no help text for READAHEAD_ALLOW_OVERHEADS Message-ID: <20060627144019.GA13915@stusta.de> References: <20060627015211.ce480da6.akpm@osdl.org> <20060627091429.GK23314@stusta.de> <20060627134337.GA6117@mail.ustc.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060627134337.GA6117@mail.ustc.edu.cn> User-Agent: Mutt/1.5.11+cvs20060403 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 27, 2006 at 09:43:37PM +0800, Wu Fengguang wrote: > On Tue, Jun 27, 2006 at 11:14:29AM +0200, Adrian Bunk wrote: > > On Tue, Jun 27, 2006 at 01:52:11AM -0700, Andrew Morton wrote: > > >... > > > Changes since 2.6.17-mm2: > > > +readahead-kconfig-option-readahead_allow_overheads.patch > > >... > > > readahead updates > > >... > > > > The READAHEAD_ALLOW_OVERHEADS option lacks a help text. > > Oh, it just acts as a submenu and a reminder ;) > > > Additionally, the "default n" is pointless and should be removed. > > I expect the _extra_ features are useless for normal users. > Your reasoning or feeling? >... That's not my point, my point is that if you remove the "default n" line, nothing changes. The default is still "n", but it's better readable. > Wu cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed